908138 - [OS.File] Detect attempts to pass relative paths to file functions

Status: RESOLVED WONTFIX

(Toolkit Graveyard :: OS.File, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

At the moment, we can pass any string as a path to the functions and methods of OS.File. Passing a relative path is a bad idea, as this is both fragile and generally not portable.

We should detect any attempt to pass a relative path and throw an error.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Not sure why this was left open as the other had both discussion and CCs - copying those CCs here.

Comment 3

[:Paolo Amadini]

Attachment: The patch

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Is there anything missing before you can land that bug?

Comment 5

[:Paolo Amadini]

(In reply to David Rajchenbach Teller [:Yoric] (please use "needinfo?") from comment #4)
> Is there anything missing before you can land that bug?

Failures in tests that use relative directories:

https://tbpl.mozilla.org/?tree=Try&rev=fd75d818fc60

I don't think I'll be able to work on fixing these in the immediate future.

Comment 6

[:Paolo Amadini]

Attachment: Bug 908138 - Detect attempts to pass relative paths to file functions.

Review commit: https://reviewboard.mozilla.org/r/261442/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/261442/

Comment 7

[:Paolo Amadini]

Attachment: Bug 908138 - Detect attempts to pass relative paths to file functions.

Review commit: https://reviewboard.mozilla.org/r/261442/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/261442/

Comment 8

[:Paolo Amadini]

I've uploaded a rebased patch and started a tryserver build in case someone wants to take a look at the test failures:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2ee0c818c41d183312ba667ce73e017d39f1d4d

Comment 9

[Beth Rennie [:beth] (she/her)]

IOUtils supersedes OS.File and does not support relative paths.