Closed
Bug 908141
Opened 8 years ago
Closed 8 years ago
Password manager does not work on script-generated forms
Categories
(SeaMonkey :: Passwords & Permissions, defect)
SeaMonkey
Passwords & Permissions
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.23
People
(Reporter: philip.chee, Assigned: neil)
References
Details
Attachments
(1 file)
1.79 KB,
patch
|
mcsmurf
:
review+
|
Details | Diff | Splinter Review |
We should port the front end changes from Bug 355063 (Password manager does not work on script-generated forms). From IRC: 10:47 * NeilAway notices bug 355063 will need a small port 10:47 thebot Bug https://bugzilla.mozilla.org/show_bug.cgi?id=355063 nor, --, ---, dolske, NEW, Password manager does not work on script-generated forms
Assignee | ||
Comment 1•8 years ago
|
||
Actually passwords don't prefill on trunk at all without this patch unless you toggle the temporary backend preference.
Comment 2•8 years ago
|
||
Philip: Did you mean to set status-seamonkey2.21/22: fixed here?
![]() |
Reporter | |
Comment 3•8 years ago
|
||
> Philip: Did you mean to set status-seamonkey2.21/22: fixed here?
Eeek! No. I wonder how that happened?
status-seamonkey2.21:
fixed → ---
status-seamonkey2.22:
fixed → ---
Comment 4•8 years ago
|
||
Neil: Did you test the fix with the testcase from Attachment 694735 [details]? Because the testcase does not work for me with the patch.
Assignee | ||
Comment 5•8 years ago
|
||
I'd just tested a regular prefill, which doesn't work without the patch. I didn't notice that attachment, I'll look into it now.
Assignee | ||
Comment 6•8 years ago
|
||
(In reply to Frank Wein from comment #4) > Neil: Did you test the fix with the testcase from attachment 694735 [details]? > Because the testcase does not work for me with the patch. It works for me. Did you turn off signon.autofillForms to test bug 886990?
Comment 7•8 years ago
|
||
Comment on attachment 796104 [details] [diff] [review] Proposed patch After clobbering locally the patch does do what it should. No idea why it did not work before (maybe some cache thing? did not really try to figure out).
Attachment #796104 -
Flags: review?(bugzilla) → review+
Assignee | ||
Comment 9•8 years ago
|
||
You need to start reading the status meeting round table updates. Also, have you not noticed that the trees have been busted most of the past fortnight?
Flags: needinfo?(neil)
Assignee | ||
Comment 10•8 years ago
|
||
Pushed comm-central changeset 9bbb4e693d4e.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.23
You need to log in
before you can comment on or make changes to this bug.
Description
•