Closed Bug 908141 Opened 7 years ago Closed 7 years ago

Password manager does not work on script-generated forms

Categories

(SeaMonkey :: Passwords & Permissions, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.23

People

(Reporter: philip.chee, Assigned: neil)

References

Details

Attachments

(1 file)

We should port the front end changes from Bug 355063 (Password manager does not work on script-generated forms).

From IRC:

10:47	* NeilAway notices bug 355063 will need a small port
10:47	thebot	Bug https://bugzilla.mozilla.org/show_bug.cgi?id=355063 nor, --, ---, dolske, NEW, Password manager does not work on script-generated forms
Attached patch Proposed patchSplinter Review
Actually passwords don't prefill on trunk at all without this patch unless you toggle the temporary backend preference.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #796104 - Flags: review?(bugzilla)
Philip: Did you mean to set status-seamonkey2.21/22: fixed here?
> Philip: Did you mean to set status-seamonkey2.21/22: fixed here?
Eeek! No. I wonder how that happened?
Neil: Did you test the fix with the testcase from Attachment 694735 [details]? Because the testcase does not work for me with the patch.
I'd just tested a regular prefill, which doesn't work without the patch.

I didn't notice that attachment, I'll look into it now.
(In reply to Frank Wein from comment #4)
> Neil: Did you test the fix with the testcase from attachment 694735 [details]?
> Because the testcase does not work for me with the patch.

It works for me. Did you turn off signon.autofillForms to test bug 886990?
Comment on attachment 796104 [details] [diff] [review]
Proposed patch

After clobbering locally the patch does do what it should. No idea why it did not work before (maybe some cache thing? did not really try to figure out).
Attachment #796104 - Flags: review?(bugzilla) → review+
Hey Neil, this patch needs to land :)
Flags: needinfo?(neil)
You need to start reading the status meeting round table updates.

Also, have you not noticed that the trees have been busted most of the past fortnight?
Flags: needinfo?(neil)
Pushed comm-central changeset 9bbb4e693d4e.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.23
You need to log in before you can comment on or make changes to this bug.