908141 - Password manager does not work on script-generated forms

Status: RESOLVED FIXED

(SeaMonkey :: Passwords & Permissions, defect)

Description

[Philip Chee]

We should port the front end changes from Bug 355063 (Password manager does not work on script-generated forms).

From IRC:

10:47	* NeilAway notices bug 355063 will need a small port
10:47	thebot	Bug https://bugzilla.mozilla.org/show_bug.cgi?id=355063 nor, --, ---, dolske, NEW, Password manager does not work on script-generated forms

Comment 1

[[e-mail]]

Attachment: Proposed patch

Actually passwords don't prefill on trunk at all without this patch unless you toggle the temporary backend preference.

Comment 2

[Frank Wein [:mcsmurf]]

Philip: Did you mean to set status-seamonkey2.21/22: fixed here?

Comment 3

[Philip Chee]

> Philip: Did you mean to set status-seamonkey2.21/22: fixed here?
Eeek! No. I wonder how that happened?

Comment 4

[Frank Wein [:mcsmurf]]

Neil: Did you test the fix with the testcase from Attachment 694735 [details]? Because the testcase does not work for me with the patch.

Comment 5

[[e-mail]]

I'd just tested a regular prefill, which doesn't work without the patch.

I didn't notice that attachment, I'll look into it now.

Comment 6

[[e-mail]]

(In reply to Frank Wein from comment #4)
> Neil: Did you test the fix with the testcase from attachment 694735 [details]?
> Because the testcase does not work for me with the patch.

It works for me. Did you turn off signon.autofillForms to test bug 886990?

Comment 7

[Frank Wein [:mcsmurf]]

Comment on attachment 796104 [details] [diff] [review]
Proposed patch

After clobbering locally the patch does do what it should. No idea why it did not work before (maybe some cache thing? did not really try to figure out).

Comment 8

[Frank Wein [:mcsmurf]]

Hey Neil, this patch needs to land :)

Comment 9

[[e-mail]]

You need to start reading the status meeting round table updates.

Also, have you not noticed that the trees have been busted most of the past fortnight?

Comment 10

[[e-mail]]

Pushed comm-central changeset 9bbb4e693d4e.