Closed Bug 908206 Opened 11 years ago Closed 9 years ago

Failure in testPrivateDownloadPanel.js due to changes in nsIDownloadManager

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

defect

Tracking

(firefox35 disabled, firefox36 disabled, firefox37 disabled, firefox38 fixed, firefox-esr31 disabled)

RESOLVED FIXED
Tracking Status
firefox35 --- disabled
firefox36 --- disabled
firefox37 --- disabled
firefox38 --- fixed
firefox-esr31 --- disabled

People

(Reporter: AndreeaMatei, Assigned: teodruta)

References

()

Details

(Whiteboard: [mozmill-test-failure][regression][mozmill-test-skipped][Blocked by bug 908649])

Attachments

(1 file)

Started failing today, most likely after the changes from bug 847863. Happens with Nightly on all platforms and locales.

Currently investigating.
Priority: -- → P1
Cosmin, could you please create a skip patch for this so I can land it? Thanks.
Attached patch skip.patchSplinter Review
Skip patch attached.

Fix might take a while, the plan is to remove nsiDownloadManager completely, don't know yet how much code we will need to update.
Assignee: nobody → andrei.eftimie
Status: NEW → ASSIGNED
Attachment #794044 - Flags: review?(andreea.matei)
Comment on attachment 794044 [details] [diff] [review]
skip.patch

Review of attachment 794044 [details] [diff] [review]:
-----------------------------------------------------------------

Skipped:
http://hg.mozilla.org/qa/mozmill-tests/rev/20a1239372ff (default)
Attachment #794044 - Flags: review?(andreea.matei) → review+
Whiteboard: [mozmill-test-failure][regression] → [mozmill-test-failure][regression][mozmill-test-skipped]
Depends on: 908649
Do we have any update here? This P1 is skipped for a whole month now without any further action taking place.
We need to completely recreate the downloads lib as the new architecture is very different from the old one. I've tried just updating code to use the new API's but I failed halfway through as architecturally they don't match at all. The old lib doesn't make any more sense with the new async promise-based API's.

I've spun off bug 908649 for this.
(In reply to Andrei Eftimie from comment #5)
> I've spun off bug 908649 for this.

I know, but also there no work happened in the last whole month. Not even a comment about the current state or any feedback requests because of possible blockers.
Assignee: andrei.eftimie → nobody
Status: ASSIGNED → NEW
Assignee: nobody → daniel.gherasim
Status: NEW → ASSIGNED
Whiteboard: [mozmill-test-failure][regression][mozmill-test-skipped] → [mozmill-test-failure][regression][mozmill-test-skipped][Blocked by bug 908649]
Backed out skip patch:
https://hg.mozilla.org/qa/mozmill-tests/rev/8dd6c8c1b7ef (default)

This will ride the trains along with the downloads refactor.
Assignee: danisielm → teodor.druta
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: