Closed
Bug 908214
Opened 11 years ago
Closed 10 years ago
Let's use nose.tools.(eq_|ok_) instead of self.assertEqual and self.assertTrue
Categories
(Socorro :: General, task)
Tracking
(Not tracked)
RESOLVED
FIXED
79
People
(Reporter: peterbe, Assigned: peterbe)
Details
(Whiteboard: [refactoring])
Having nose is a must anyway so the `from nose.tools import eq_, ok_` should always work. The convention is quite trivial but it basically makes the code lighter because you can save a lot of typing.
Assignee | ||
Updated•11 years ago
|
Whiteboard: [refactoring]
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → peterbe
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•10 years ago
|
||
https://github.com/mozilla/socorro/pull/1949
Comment 2•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/c0e4c624879b637081d9623c590ca7f7e2deb844 fixes bug 908214 - eq_ and ok_ instead of assertEqual and assertTrue, r=rhelmer
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 3•10 years ago
|
||
Reopen because, as Adrian pointed out, we should change self.assertRaises to `nose.tools.assert_raises` too.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•10 years ago
|
Target Milestone: --- → 78
Comment 4•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/56978a246ab00298614830b18eae71aa2c523245 fixes bug 908214 - replace self.assertRaises with assert_raises, r=AdrianGaudebert
Updated•10 years ago
|
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Target Milestone: 78 → 79
You need to log in
before you can comment on or make changes to this bug.
Description
•