Closed Bug 908214 Opened 12 years ago Closed 11 years ago

Let's use nose.tools.(eq_|ok_) instead of self.assertEqual and self.assertTrue

Categories

(Socorro :: General, task)

Product:
Socorro
Component:
General
Platform:
x86
macOS
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: peterbe, Assigned: peterbe)

Details

(Whiteboard: [refactoring])

Having nose is a must anyway so the `from nose.tools import eq_, ok_` should always work. The convention is quite trivial but it basically makes the code lighter because you can save a lot of typing.
Whiteboard: [refactoring]
Assignee: nobody → peterbe
Status: NEW → ASSIGNED
Commit pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/c0e4c624879b637081d9623c590ca7f7e2deb844 fixes bug 908214 - eq_ and ok_ instead of assertEqual and assertTrue, r=rhelmer
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Reopen because, as Adrian pointed out, we should change self.assertRaises to `nose.tools.assert_raises` too.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: --- → 78
Commit pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/56978a246ab00298614830b18eae71aa2c523245 fixes bug 908214 - replace self.assertRaises with assert_raises, r=AdrianGaudebert
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Target Milestone: 78 → 79
You need to log in before you can comment on or make changes to this bug.