Closed Bug 908248 Opened 10 years ago Closed 10 years ago

Intermittent test_tcpserversocket.js | got unexpected: open (args: ) | got unexpected: servererror (args: [object DOMError])

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla27
Tracking Flags:
Tracking Status
firefox25 --- unaffected
firefox26 --- fixed
firefox27 --- fixed
firefox-esr24 --- unaffected

People

(Reporter: emorley, Assigned: tm-konno)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 2 obsolete files)

A patch correcting test for tcp server socket
1.27 KB, patch
Details | Diff | Splinter Review 
Rev4 MacOSX Lion 10.7 mozilla-inbound opt test xpcshell on 2013-08-22 08:02:13 PDT for push a155905a9d08

slave: talos-r4-lion-064

https://tbpl.mozilla.org/php/getParsedLog.php?id=26872761&tree=Mozilla-Inbound

{
08:06:20     INFO -  TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/dom/network/tests/unit/test_tcpserversocket.js | Starting openSockInClosingServer
08:06:20     INFO -  TEST-INFO | (xpcshell/head.js) | test openSockInClosingServer pending (2)
08:06:20     INFO -  TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/dom/network/tests/unit/test_tcpserversocket.js | "got expected: clientnotopen"
08:06:20     INFO -  TEST-INFO | (xpcshell/head.js) | test run_next_test 8 pending (3)
08:06:20     INFO -  TEST-INFO | (xpcshell/head.js) | test openSockInClosingServer finished (3)
08:06:20     INFO -  TEST-INFO | (xpcshell/head.js) | test run_next_test 7 finished (2)
08:06:20     INFO -  TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/dom/network/tests/unit/test_tcpserversocket.js | Starting cleanup
08:06:20     INFO -  TEST-INFO | (xpcshell/head.js) | test cleanup pending (2)
08:06:20     INFO -  TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/dom/network/tests/unit/test_tcpserversocket.js | "Cleaning up"
08:06:20     INFO -  TEST-INFO | (xpcshell/head.js) | test run_next_test 9 pending (3)
08:06:20     INFO -  TEST-INFO | (xpcshell/head.js) | test cleanup finished (3)
08:06:20     INFO -  TEST-INFO | (xpcshell/head.js) | test run_next_test 8 finished (2)
08:06:20     INFO -  TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/dom/network/tests/unit/test_tcpserversocket.js | Starting connectSock
08:06:20     INFO -  TEST-INFO | (xpcshell/head.js) | test connectSock pending (2)
08:06:20     INFO -  TEST-INFO | (xpcshell/head.js) | test run_next_test 9 finished (2)
08:06:20  WARNING -  TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/dom/network/tests/unit/test_tcpserversocket.js | got unexpected: open (args: ) - see following stack:
08:06:20     INFO -  JS frame :: /builds/slave/talos-slave/test/build/tests/xpcshell/tests/dom/network/tests/unit/test_tcpserversocket.js :: makeFailureCase/< :: line 95
08:06:20     INFO -  JS frame :: jar:file:///builds/slave/talos-slave/test/build/application/FirefoxNightly.app/Contents/MacOS/omni.ja!/components/TCPSocket.js :: ts_callListener :: line 298
08:06:20     INFO -  JS frame :: jar:file:///builds/slave/talos-slave/test/build/application/FirefoxNightly.app/Contents/MacOS/omni.ja!/components/TCPSocket.js :: ts_onTransportStatus :: line 701
08:06:20     INFO -  native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
08:06:20     INFO -  TEST-INFO | (xpcshell/head.js) | exiting test
08:06:20     INFO -  TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/dom/network/tests/unit/test_tcpserversocket.js | "got expected: serveropen"
08:06:20     INFO -  TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/dom/network/tests/unit/test_tcpserversocket.js | "got expected: serveropen"
08:06:20     INFO -  TEST-INFO | (xpcshell/head.js) | test run_next_test 10 pending (2)
08:06:20     INFO -  TEST-INFO | (xpcshell/head.js) | test connectSock finished (2)
08:06:20     INFO -  TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/dom/network/tests/unit/test_tcpserversocket.js | "got expected: clientopen"
08:06:20  WARNING -  TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/dom/network/tests/unit/test_tcpserversocket.js | got unexpected: servererror (args: [object DOMError]) - see following stack:
08:06:20     INFO -  JS frame :: /builds/slave/talos-slave/test/build/tests/xpcshell/tests/dom/network/tests/unit/test_tcpserversocket.js :: makeFailureCase/< :: line 95
08:06:20     INFO -  JS frame :: jar:file:///builds/slave/talos-slave/test/build/application/FirefoxNightly.app/Contents/MacOS/omni.ja!/components/TCPSocket.js :: ts_callListener :: line 298
08:06:20     INFO -  JS frame :: jar:file:///builds/slave/talos-slave/test/build/application/FirefoxNightly.app/Contents/MacOS/omni.ja!/components/TCPSocket.js :: TCPSocket.prototype._maybeReportErrorAndCloseIfOpen :: line 691
08:06:20     INFO -  JS frame :: jar:file:///builds/slave/talos-slave/test/build/application/FirefoxNightly.app/Contents/MacOS/omni.ja!/components/TCPSocket.js :: ts_onInputStreamReady :: line 722
08:06:20     INFO -  native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
}
Tomoaki, can you investigate these test failures?  Thanks!
Assignee: nobody → tm-konno
Yes. I can investigate them.

        Attachment #814321 -
        Flags: feedback?(overholt)

    
    

    
  
I guess that there is a bug in the test for "openSockInClosingServer".
"success()" was evaluated shortly without waiting to call "sock.onerror".

In addition, the codes for timeout in "run_test" is removed based on the following bug.
https://bugzilla.mozilla.org/show_bug.cgi?id=869638

    
  

        Attachment #814321 -
        Flags: feedback?(overholt) → review+

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  
Tomoaki, are you able to land the changes here?  I see jdm gave his r+.
Flags: needinfo?(tm-konno)

    
    

    
      
  

    
    

    
  
(In reply to Andrew Overholt [:overholt] from comment #103)
> Tomoaki, are you able to land the changes here?  I see jdm gave his r+.

No, because I haven't understood the process to land them yet.
Flags: needinfo?(tm-konno)

    
    

    
  
If you attach a patch with a commit message and author data, you can use the checkin-needed keyword and someone will do it for you.

    
    

    
      
  

    
    

    
  


  

        Attachment #814321 -
        Attachment is obsolete: true

        Attachment #821464 -
        Flags: checkin?

    
    

    
  
Thanks, Josh and Ed.
Is this right to land them?
I'd like to ask someone to check-in this patch.

    
    

    
      
  

    
    

    
      
  

    
    

    
  
r=josh is Josh Aas; I'm r=jdm. Otherwise it's fine. Be sure to use the checkin-needed keyword (see the keywords field up top) instead of the checkin? flag.

    
    

    
  


  

        Attachment #821464 -
        Attachment is obsolete: true

        Attachment #821464 -
        Flags: checkin?

    
  
Keywords: intermittent-failure → checkin-needed

    
    

    
  
Thanks, Josh. r=jdm is correct.

    
  
Keywords: intermittent-failure

    
    

    
      
  

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/c8b7c62b1431
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27

    
    

    
      
  
Component: DOM → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.