908351 - Stop over-including DOMJSClass.h

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

DOMJSClass depends on PrototypeList, so any time a binding is added stuff including it ends up rebuilding...

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Stop over-including DOMJSClass.h, so we don't rebuild as much when PrototypeList.h changes. We do this by factoring out the slot macros into a separate header and including that.

Comment 2

[Boris Zbarsky [:bzbarsky]]

https://tbpl.mozilla.org/?tree=Try&rev=f9252a0f58d1

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 794188 [details] [diff] [review]
Stop over-including DOMJSClass.h, so we don't rebuild as much when PrototypeList.h changes.  We do this by factoring out the slot macros into a separate header and including that.

Review of attachment 794188 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/JSSlots.h
@@ +2,5 @@
> +/* This Source Code Form is subject to the terms of the Mozilla Public
> + * License, v. 2.0. If a copy of the MPL was not distributed with this file,
> + * You can obtain one at http://mozilla.org/MPL/2.0/. */
> +
> +#ifndef mozilla_dom_DOMSlots_h

Would be nice to have a one-line comment here to describe the purpose of the header

Comment 4

[Boris Zbarsky [:bzbarsky]]

> Would be nice to have a one-line comment here to describe the purpose of the header

Done.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e6d3fd6af606

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e6d3fd6af606