Closed Bug 908351 Opened 8 years ago Closed 8 years ago

Stop over-including DOMJSClass.h

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

DOMJSClass depends on PrototypeList, so any time a binding is added stuff including it ends up rebuilding...
Blocks: includehell
Comment on attachment 794188 [details] [diff] [review]
Stop over-including DOMJSClass.h, so we don't rebuild as much when PrototypeList.h changes.  We do this by factoring out the slot macros into a separate header and including that.

Review of attachment 794188 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/JSSlots.h
@@ +2,5 @@
> +/* This Source Code Form is subject to the terms of the Mozilla Public
> + * License, v. 2.0. If a copy of the MPL was not distributed with this file,
> + * You can obtain one at http://mozilla.org/MPL/2.0/. */
> +
> +#ifndef mozilla_dom_DOMSlots_h

Would be nice to have a one-line comment here to describe the purpose of the header
> Would be nice to have a one-line comment here to describe the purpose of the header

Done.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e6d3fd6af606
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla26
https://hg.mozilla.org/mozilla-central/rev/e6d3fd6af606
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.