908377 - Interactive content blocking screen has typos

Status: RESOLVED FIXED

(Firefox :: Security, defect)

Description

[Nathan2055]

Attachment: A screenshot of the typos

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 (Beta/Release)
Build ID: 20130822030204

Steps to reproduce:

1. Go to https://twitter.com/dinnerbone
2. Wait a second
3. The warning icon alerting you that insecure scripts have been disabled should appear
4. Click on the icon


Actual results:

A screen appears that is supposed to explain to users that insecure scripts have been blocked.


Expected results:

The screen appears, but is full of typos (see screenshot). Related to bug 782654.

Comment 1

[Mihai Morar, (:MihaiMorar)]

I am not able to see the warning icon but I can see the lock icon which says that the page is Verified by VeriSign, Inc which is expected. Can you please take a look to you about:config prefs and make sure 
"network.websocket.allowInsecureFromHTTPS" is set to false

Comment 2

[Mihai Morar, (:MihaiMorar)]

Probably fixed by Bug 912817. Can you still see this issue on Latest Nightly builds?

Comment 3

[Tanvi Vyas[:tanvi]]

We were showing the wrong message in one case and fixed that with bug 912817.  But I'm not sure if that is the typo that Nathan is referring to.

If you go to https://people.mozilla.com/~tvyas/mixeddisplay.html which has mixed display content in Firefox 26, you will see this message:
The connection to this website is not fully secure because it contains unencrypted elements (such as images).

If you go to https://people.mozilla.com/~tvyas/mixedcontent.html which has mixed active content blocked in Firefox 26, you will see this message:
Interactive content (such as script) that isn't encrypted has been blocked for your protection.

Nathan, are there specific typos you see here?  Thanks!

Comment 4

[Nathan2055]

(In reply to Tanvi Vyas [:tanvi] from comment #3)
> We were showing the wrong message in one case and fixed that with bug
> 912817.  But I'm not sure if that is the typo that Nathan is referring to.
> 
> If you go to https://people.mozilla.com/~tvyas/mixeddisplay.html which has
> mixed display content in Firefox 26, you will see this message:
> The connection to this website is not fully secure because it contains
> unencrypted elements (such as images).
> 
> If you go to https://people.mozilla.com/~tvyas/mixedcontent.html which has
> mixed active content blocked in Firefox 26, you will see this message:
> Interactive content (such as script) that isn't encrypted has been blocked
> for your protection.
> 
> Nathan, are there specific typos you see here?  Thanks!

The only one that sticks out to me is "such as script". Shouldn't it be "such as scripts"?

Comment 5

[Tanvi Vyas[:tanvi]]

(In reply to Nathan2055 from comment #4)
> > If you go to https://people.mozilla.com/~tvyas/mixedcontent.html which has
> > mixed active content blocked in Firefox 26, you will see this message:
> > Interactive content (such as script) that isn't encrypted has been blocked
> > for your protection.
> > 
> > Nathan, are there specific typos you see here?  Thanks!
> 
> The only one that sticks out to me is "such as script". Shouldn't it be
> "such as scripts"?

Yes, we went back and forth on this one, since we had difficulty between what was grammatically correct and what sounded okay when it came to singulars and plurals (see bug https://bugzilla.mozilla.org/show_bug.cgi?id=838402#c14 for the history).

Regardless, we ended up taking this string out entirely in Firefox 26 for other reasons (see bug https://bugzilla.mozilla.org/show_bug.cgi?id=913710).

http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/browser.properties#260