908476 - GeckoProfiler.h:119:15: error: unknown type name 'JSObject' (non-SPS)

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Jan Beich]

On platforms without SPS profiler the build is broken due to
GeckoProfiler.h not declaring class JSObject (unlike GeckoProfilerFunc.h).

In file included from xpcom/base/nsMemoryReporterManager.cpp:23:
In file included from dist/include/mozilla/Telemetry.h:11:
In file included from dist/include/mozilla/StartupTimeline.h:26:
dist/include/GeckoProfiler.h:119:15: error: unknown type name 'JSObject'
static inline JSObject* profiler_get_profile_jsobject(JSContext* aCx) { retu...
              ^
dist/include/GeckoProfiler.h:119:55: error: unknown type name 'JSContext'
static inline JSObject* profiler_get_profile_jsobject(JSContext* aCx) { retu...
                                                      ^
2 errors generated.

Comment 1

[Jan Beich]

Attachment: declare early

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 794306 [details] [diff] [review]
declare early

Review of attachment 794306 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Jan Beich]

Comment on attachment 794306 [details] [diff] [review]
declare early

Review of attachment 794306 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/profiler/GeckoProfilerFunc.h
@@ -13,5 @@
>  using mozilla::TimeStamp;
>  using mozilla::TimeDuration;
>  
> -struct JSContext;
> -class JSObject;

Oops, removing them would break SPS profiler implementation
where build would stop somewhere in tools/profiler/.

Comment 4

[Jan Beich]

Attachment: declare for non-sps, v2

Comment 5

[Landry Breuil (:gaston)]

Landed att 794338 : https://hg.mozilla.org/integration/mozilla-inbound/rev/1ae8a6bb3def

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1ae8a6bb3def