Closed
Bug 908507
Opened 12 years ago
Closed 12 years ago
IonMonkey: Remove unused scriptList() from IonScript
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: efaust, Assigned: efaust)
Details
Attachments
(2 files)
10.52 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
3.50 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
While tooling around in IonCode.h, I noticed that the list of inlined scripts that we store in the IonScript is totally unused.
It looks like Jan added it about a year ago for JM cache invalidation. With JM gone, there should be no more uses. We should remove it for cleanliness, and to free up some space.
Assignee | ||
Comment 1•12 years ago
|
||
Assignee: general → efaustbmo
Status: NEW → ASSIGNED
Attachment #794346 -
Flags: review?(nicolas.b.pierron)
Comment 2•12 years ago
|
||
Comment on attachment 794346 [details] [diff] [review]
Patch
Review of attachment 794346 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/jit/CodeGenerator.cpp
@@ -5616,5 @@
> ionScript->copySnapshots(&snapshots_);
> if (graph.numConstants())
> ionScript->copyConstants(graph.constantPool());
> - JS_ASSERT(graph.mir().numScripts() > 0);
> - ionScript->copyScriptEntries(graph.mir().scripts());
By the way, this seems to be the only use of this vector. We can also prune that from IonBuilder and from the MIR Graph.
Attachment #794346 -
Flags: review?(nicolas.b.pierron) → review+
Assignee | ||
Comment 3•12 years ago
|
||
(In reply to Nicolas B. Pierron [:nbp] from comment #2)
> By the way, this seems to be the only use of this vector. We can also prune
> that from IonBuilder and from the MIR Graph.
Done.
Attachment #794354 -
Flags: review?(nicolas.b.pierron)
Updated•12 years ago
|
Attachment #794354 -
Flags: review?(nicolas.b.pierron) → review+
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3975ebdc695
folded and pushed.
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•