Closed Bug 908507 Opened 8 years ago Closed 8 years ago

IonMonkey: Remove unused scriptList() from IonScript

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: efaust, Assigned: efaust)

Details

Attachments

(2 files)

While tooling around in IonCode.h, I noticed that the list of inlined scripts that we store in the IonScript is totally unused.

It looks like Jan added it about a year ago for JM cache invalidation. With JM gone, there should be no more uses.  We should remove it for cleanliness, and to free up some space.
Attached patch PatchSplinter Review
Assignee: general → efaustbmo
Status: NEW → ASSIGNED
Attachment #794346 - Flags: review?(nicolas.b.pierron)
Comment on attachment 794346 [details] [diff] [review]
Patch

Review of attachment 794346 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/CodeGenerator.cpp
@@ -5616,5 @@
>          ionScript->copySnapshots(&snapshots_);
>      if (graph.numConstants())
>          ionScript->copyConstants(graph.constantPool());
> -    JS_ASSERT(graph.mir().numScripts() > 0);
> -    ionScript->copyScriptEntries(graph.mir().scripts());

By the way, this seems to be the only use of this vector.  We can also prune that from IonBuilder and from the MIR Graph.
Attachment #794346 - Flags: review?(nicolas.b.pierron) → review+
Attached patch Part 2Splinter Review
(In reply to Nicolas B. Pierron [:nbp] from comment #2)
> By the way, this seems to be the only use of this vector.  We can also prune
> that from IonBuilder and from the MIR Graph.

Done.
Attachment #794354 - Flags: review?(nicolas.b.pierron)
Attachment #794354 - Flags: review?(nicolas.b.pierron) → review+
https://hg.mozilla.org/mozilla-central/rev/b3975ebdc695
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.