908507 - IonMonkey: Remove unused scriptList() from IonScript

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Eric Faust [:efaust]]

While tooling around in IonCode.h, I noticed that the list of inlined scripts that we store in the IonScript is totally unused.

It looks like Jan added it about a year ago for JM cache invalidation. With JM gone, there should be no more uses.  We should remove it for cleanliness, and to free up some space.

Comment 1

[Eric Faust [:efaust]]

Attachment: Patch

Comment 2

[Nicolas B. Pierron [:nbp]]

Comment on attachment 794346 [details] [diff] [review]
Patch

Review of attachment 794346 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/CodeGenerator.cpp
@@ -5616,5 @@
>          ionScript->copySnapshots(&snapshots_);
>      if (graph.numConstants())
>          ionScript->copyConstants(graph.constantPool());
> -    JS_ASSERT(graph.mir().numScripts() > 0);
> -    ionScript->copyScriptEntries(graph.mir().scripts());

By the way, this seems to be the only use of this vector.  We can also prune that from IonBuilder and from the MIR Graph.

Comment 3

[Eric Faust [:efaust]]

Attachment: Part 2

(In reply to Nicolas B. Pierron [:nbp] from comment #2)
> By the way, this seems to be the only use of this vector.  We can also prune
> that from IonBuilder and from the MIR Graph.

Done.

Comment 4

[Eric Faust [:efaust]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b3975ebdc695

folded and pushed.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b3975ebdc695