Closed
Bug 908527
Opened 12 years ago
Closed 12 years ago
Wasted work in PSM_SSL_BlacklistDigiNotar()
Categories
(Core :: Security: PSM, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: pchang9, Assigned: pchang9)
Details
(Keywords: perf)
Attachments
(1 file)
|
1.07 KB,
patch
|
cviecco
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20100101 Firefox/19.0 (Beta/Release)
Build ID: 20130316161634
Steps to reproduce:
The problem appears in changeset 138350:18467a85acf6. I have attached a simple one-line patch that fixes it.
In method PSM_SSL_BlacklistDigiNotar() in security/manager/ssl/src/SSLServerCertVerification.cpp, the loop on line 740 should break immediately after "isDigiNotarIssuedCert" is set to "true". All the iterations after "isDigiNotarIssuedCert" is set to "true" do not perform any useful work, at best they just set "isDigiNotarIssuedCert" again to "true".
Attachment #794386 -
Flags: review?(cviecco)
|
||
Updated•12 years ago
|
Component: Untriaged → Security: PSM
Product: Firefox → Core
|
||
Comment 2•12 years ago
|
||
Comment on attachment 794386 [details] [diff] [review]
908527.patch
Review of attachment 794386 [details] [diff] [review]:
-----------------------------------------------------------------
Simple an effective. Thanks.
Attachment #794386 -
Flags: review?(cviecco) → review+
Landed on try server:
https://tbpl.mozilla.org/?tree=Try&rev=0c4c2f056696
Keywords: checkin-needed
|
||
Comment 4•12 years ago
|
||
Assignee: nobody → pchang9
Keywords: checkin-needed
|
|
||
Comment 5•12 years ago
|
||
Status: UNCONFIRMED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•