Closed Bug 908527 Opened 10 years ago Closed 10 years ago

Wasted work in PSM_SSL_BlacklistDigiNotar()

Categories

(Core :: Security: PSM, defect)

Product:
Core
Component:
Security: PSM
Platform:
x86_64
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla26

People

(Reporter: pchang9, Assigned: pchang9)

Details

(Keywords: perf)

Attachments

(1 file)

908527.patch
1.07 KB, patch
cviecco
: review+
Details | Diff | Splinter Review 
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20100101 Firefox/19.0 (Beta/Release)
Build ID: 20130316161634

Steps to reproduce:

The problem appears in changeset 138350:18467a85acf6. I have attached a simple one-line patch that fixes it.

In method PSM_SSL_BlacklistDigiNotar() in security/manager/ssl/src/SSLServerCertVerification.cpp, the loop on line 740 should break immediately after "isDigiNotarIssuedCert" is set to "true". All the iterations after "isDigiNotarIssuedCert" is set to "true" do not perform any useful work, at best they just set "isDigiNotarIssuedCert" again to "true".
Keywords: perf
OS: Linux → All
Version: 19 Branch → Trunk
Attached patch 908527.patch — — Splinter Review 

        Attachment #794386 -
        Flags: review?(cviecco)
Component: Untriaged → Security: PSM
Product: Firefox → Core

    
    

    
  
Comment on attachment 794386 [details] [diff] [review]
908527.patch

Review of attachment 794386 [details] [diff] [review]:
-----------------------------------------------------------------

Simple an effective. Thanks.

        Attachment #794386 -
        Flags: review?(cviecco) → review+

    
    

    
  
Landed on try server:
https://tbpl.mozilla.org/?tree=Try&rev=0c4c2f056696

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/192825330b3e
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26

          You need to log in
          before you can comment on or make changes to this bug.