908530 - Stop including xpcpublic.h in DOMJSProxyHandler.h

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Patch coming up; unfortunately all sorts of stuff was bootlegged via xpcpublic.h various places.  :(

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Fix all the places that are bootlegging things (esp nsIURI) via xpcpublic.h.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Make Link::GetURI return a raw pointer so we don't have to include nsIURI.h in Link.h.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Stop including xpcpublic.h in DOMJSProxyHandler.h.

Comment 4

[Boris Zbarsky [:bzbarsky]]

https://tbpl.mozilla.org/?tree=Try&rev=92c0a0b2a5d5

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 794502 [details] [diff] [review]
part 1.  Make Link::GetURI return a raw pointer so we don't have to include nsIURI.h in Link.h.

Review of attachment 794502 [details] [diff] [review]:
-----------------------------------------------------------------

HasURI--

::: content/base/src/Link.h
@@ +50,2 @@
>      return GetURI();
>    }

This is effectively an interface change, no?  I think you need to change the IID.

::: toolkit/components/places/tests/cpp/mock_Link.h
@@ +105,1 @@
>  Link::GetURI() const 

While you're here, remove the extra whitespace after const?

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 794503 [details] [diff] [review]
part 3.  Stop including xpcpublic.h in DOMJSProxyHandler.h.

Review of attachment 794503 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

Comment 7

[Boris Zbarsky [:bzbarsky]]

> This is effectively an interface change, no?  I think you need to change the IID.

Yes, good catch.

https://hg.mozilla.org/integration/mozilla-inbound/rev/c0d21a0f1695
https://hg.mozilla.org/integration/mozilla-inbound/rev/14db98f529bd
https://hg.mozilla.org/integration/mozilla-inbound/rev/e39cb2e48c27

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c0d21a0f1695
https://hg.mozilla.org/mozilla-central/rev/14db98f529bd
https://hg.mozilla.org/mozilla-central/rev/e39cb2e48c27