Stop including xpcpublic.h in DOMJSProxyHandler.h

RESOLVED FIXED in mozilla26

Status

()

Core
DOM
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

(Blocks: 1 bug)

unspecified
mozilla26
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

Patch coming up; unfortunately all sorts of stuff was bootlegged via xpcpublic.h various places.  :(
Created attachment 794501 [details] [diff] [review]
part 2.  Fix all the places that are bootlegging things (esp nsIURI) via xpcpublic.h.
Attachment #794501 - Flags: review?(khuey)
Created attachment 794502 [details] [diff] [review]
part 1.  Make Link::GetURI return a raw pointer so we don't have to include nsIURI.h in Link.h.
Attachment #794502 - Flags: review?(khuey)
Created attachment 794503 [details] [diff] [review]
part 3.  Stop including xpcpublic.h in DOMJSProxyHandler.h.
Attachment #794503 - Flags: review?(khuey)
https://tbpl.mozilla.org/?tree=Try&rev=92c0a0b2a5d5
Attachment #794501 - Flags: review?(khuey) → review+
Comment on attachment 794502 [details] [diff] [review]
part 1.  Make Link::GetURI return a raw pointer so we don't have to include nsIURI.h in Link.h.

Review of attachment 794502 [details] [diff] [review]:
-----------------------------------------------------------------

HasURI--

::: content/base/src/Link.h
@@ +50,2 @@
>      return GetURI();
>    }

This is effectively an interface change, no?  I think you need to change the IID.

::: toolkit/components/places/tests/cpp/mock_Link.h
@@ +105,1 @@
>  Link::GetURI() const 

While you're here, remove the extra whitespace after const?
Attachment #794502 - Flags: review?(khuey) → review+
Comment on attachment 794503 [details] [diff] [review]
part 3.  Stop including xpcpublic.h in DOMJSProxyHandler.h.

Review of attachment 794503 [details] [diff] [review]:
-----------------------------------------------------------------

\o/
Attachment #794503 - Flags: review?(khuey) → review+
> This is effectively an interface change, no?  I think you need to change the IID.

Yes, good catch.

https://hg.mozilla.org/integration/mozilla-inbound/rev/c0d21a0f1695
https://hg.mozilla.org/integration/mozilla-inbound/rev/14db98f529bd
https://hg.mozilla.org/integration/mozilla-inbound/rev/e39cb2e48c27
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla26
https://hg.mozilla.org/mozilla-central/rev/c0d21a0f1695
https://hg.mozilla.org/mozilla-central/rev/14db98f529bd
https://hg.mozilla.org/mozilla-central/rev/e39cb2e48c27
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.