Closed
Bug 908569
Opened 12 years ago
Closed 5 years ago
Remove MostVisited page from History tab
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: sriram, Assigned: sriram)
References
Details
Attachments
(2 files)
|
3.72 KB,
patch
|
lucasr
:
review-
|
Details | Diff | Splinter Review |
|
17.21 KB,
patch
|
lucasr
:
review-
|
Details | Diff | Splinter Review |
It feels redundant to have "Most visited" and "Most recent" pages. As per UX decision, its better to remove "Most visited" page.
| Assignee | ||
Comment 1•12 years ago
|
||
Ian wanted to put this in nightly for 2 days, and if people like it, remove all bits and pieces needed.
This patch:
1. hides the most recent page.
2. removes the title as it won't be needed.
3. make bookmarks default page when editing starts.
This is as per Ian's suggestion.
Attachment #794489 -
Flags: review?(lucasr.at.mozilla)
| Assignee | ||
Comment 2•12 years ago
|
||
This can be added if once UX decides on removing the page altogether.
Attachment #794500 -
Flags: review?(lucasr.at.mozilla)
| Assignee | ||
Updated•12 years ago
|
Attachment #794489 -
Attachment description: Patch → Patch: Hide
| Assignee | ||
Updated•12 years ago
|
Assignee: nobody → sriram
Blocks: new-about-home
Comment 3•12 years ago
|
||
Comment on attachment 794489 [details] [diff] [review]
Patch: Hide
Review of attachment 794489 [details] [diff] [review]:
-----------------------------------------------------------------
This idea has one major issue: without the title, it will be very hard to understand what the "Tabs from last time" tab is about. The icon alone definitely does not communicate this well enough. Furthermore, I'm not entirely sure how visually balanced the bottom tabs will look with only 2 icons. My concern here is that they might look a bit strange with so much empty space, especially in landscape orientation with the extra horizontal space.
Thoughts?
Attachment #794489 -
Flags: review?(lucasr.at.mozilla) → review-
Comment 4•12 years ago
|
||
Comment on attachment 794500 [details] [diff] [review]
Patch: Remove
Review of attachment 794500 [details] [diff] [review]:
-----------------------------------------------------------------
If you remove the title from the home_history_list layout (in the previous patch), you'll have to remove all references to the title (mTitle) in each fragment too as they will not be necessary anymore.
Attachment #794500 -
Flags: review?(lucasr.at.mozilla) → review-
Updated•12 years ago
|
Flags: needinfo?(ibarlow)
Comment 5•12 years ago
|
||
A user commented the other day in channel after hours that they liked the most visited pane because it reduced the need to type anything to access their most frequented websites. Removing this will re-introduce that inconvenience, will it not?
Comment 6•12 years ago
|
||
I thought "most recent" was a frecency sorted list, while "most visited" was the raw history. These certainly have different uses and I don't think they are redundant.
Wait until you get more than a week of history accumulated. The lists could be very different.
If you only visit the same 20 sites, then the lists might look similar, but that's not the current case in my Nightly.
Comment 7•12 years ago
|
||
Ok, let's park this discussion.
I'm getting almost equal parts Yay and Nay so far on this decision, so let's leave Top Sites in for now, and revisit a little later in the cycle.
I would however like to try changing the "tap URL bar" behaviour to land the user on Bookmarks instead of History.
Flags: needinfo?(ibarlow)
Comment 8•5 years ago
|
||
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INCOMPLETE
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•