908602 - Remove Facebook partner key from v1-train repository

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Beatriz Rodríguez [:brg]]

Please remove a partner specific key for Facebook on v1-train repository to avoid any issue.
We agreed to use Mozilla key in all the builds.

The key should be deleted from here:
https://github.com/mozilla-b2g/gaia/blob/v1-train/build/communications_services.json

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Github: https://github.com/mozilla-b2g/gaia/pull/11712

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 794556 [details] [review]
Github: https://github.com/mozilla-b2g/gaia/pull/11712

Stealing review since Jose is on PTO.

rplusing since the change is quite simple, clean and self contained.

Thanks a lot Tim!

Comment 3

[Andrew Overholt [:overholt]]

So what happens with the Mozilla builds that QA is testing?  I'm guessing they lose functionality and therefore the ability to test contact importing.

Comment 4

[Beatriz Rodríguez [:brg]]

(In reply to Andrew Overholt [:overholt] from comment #3)
> So what happens with the Mozilla builds that QA is testing?  I'm guessing
> they lose functionality and therefore the ability to test contact importing.
The official builds from v1-train are including Mozilla key now and working fine.
We only removed TEF key from a wrong place.

Comment 5

[Preeti Raghunath(:Preeti)]

Minus, since it seems like an internal clean up issue.

Comment 6

[Beatriz Rodríguez [:brg]]

Hi again, this is critical issue for us. You are including a partner specific key in your official repositories and this key should not be used anymore by any OEM with any version. The patch should land in v1-train to avoid this issue.
Again setting back the nomination to leo+

Comment 7

[Preeti Raghunath(:Preeti)]

Tim,

Please have someone complete the clean up.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1-train: https://github.com/mozilla-b2g/gaia/commit/a6a0fb84927299cdc2a0bd913b7fee8993727236

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: a6a0fb84927299cdc2a0bd913b7fee8993727236
v1.1.0hd: ffce2d70518c696a589159247b49a7d0c7833a94