908706 - Percentage text-indent handled incorrectly in overflow:hidden block

Status: RESOLVED INVALID

(Core :: Layout: Block and Inline, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase

Per spec, percentage text-indent refers to the containing block width.

We do this right usually, but if the block has a scrollframe, we seem to make it refer to the scrollframe width, which is wrong.  In the attached testcase the "CANTSEEME" text should not be visible.

Comment 1

[Boris Zbarsky [:bzbarsky]]

nsLineLayout uses nsHTMLReflowState::GetContainingBlockContentWidth(mBlockReflowState) to compute the percentage basis.... would that return the reflow state for the scrollframe?

Comment 2

[Mats Palmgren (inactive)]

Attachment: Testcase

It seems <fieldset> is wrong too (and like other cases with anon block wrappers).

Comment 3

[Mats Palmgren (inactive)]

Webkit seems to use the table, Presto the <div> as containing
block.  Gecko uses the TableCellFrame maybe?

Comment 4

[Mats Palmgren (inactive)]

Attachment: WIP

Fwiw, skipping reflow states for anon pseudo frames fixes the scroll frame and
<fieldset> cases.  Should we skip other types of pseudos too?

Comment 5

[Mats Palmgren (inactive)]

Comment 2: s/like/likely/

Comment 6

[David Baron :dbaron:]

Things tohink about:
 * can we benefit from nsIFrame::GetContainingBlock()?  (I also keep wanting an IsContainingBlock() function.)
 * should the walking be through parentReflowState or mCBReflowState?
 * is mCBReflowState even being set correctly in this case for other uses of mCBReflowState?  Maybe it's just set wrong here?

Comment 7

[Boris Zbarsky [:bzbarsky]]

Mats, are you still planning to drive this in?

Comment 8

[David Baron :dbaron:]

Bug 1453298 makes this invalid.

Comment 9

[Ting-Yu Lin [:TYLin] (UTC-8)]

Close per comment 8.