908737 - Robocop: upgrade to robotium-solo-4.2.jar

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

We're a few versions behind the robotium release, and it looks like the current release has better APIs for handling for conditional waiting, which will definitely help us clean up our tests.

We'll have to adapt the tests that use deprecated APIS from bug 855978.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

It seems there are some places in the build system that need to be updated too: https://mxr.mozilla.org/mozilla-central/search?string=robotium%20is%20updated&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

Comment 2

[Chenxia Liu [:liuche]]

Attachment: Patch: upgrade to robotium-4.2

Made a try push, let's see if it goes orange-y: https://tbpl.mozilla.org/?tree=Try&rev=ac8217d5a14b

Comment 3

[Chenxia Liu [:liuche]]

Attachment: Patch: upgrade to robotium-4.2 v2

Didn't see comment #2, added those changes. Initial try push here: https://tbpl.mozilla.org/?tree=Try&rev=364b95b737b8

Adrian: are there any other places that you've made notes to change when updating the robotium jar?

Changelog of the robotium here: http://code.google.com/p/robotium/wiki/Changelog

I think the new version includes enough new capabilities (touch swiping, wait for events, getViewById) that we would benefit from upgrading and using library methods instead of our own versions.

This initial try run is to gauge how much orange we get with this, but this patch will definitely have to go through further iterations where we replace pieces of our code with new library methods.

Comment 4

[Chenxia Liu [:liuche]]

Nice, all green try run! I'll make a first pass through the tests and see what methods can be updated to the newer version.

Comment 5

[Chenxia Liu [:liuche]]

(Link to try push here: https://tbpl.mozilla.org/?tree=Try&rev=067dec621504)

Comment 6

[Lucas Rocha (:lucasr)]

(In reply to Chenxia Liu [:liuche] from comment #4)
> Nice, all green try run! I'll make a first pass through the tests and see
> what methods can be updated to the newer version.

I suggest pushing this first, and gradually make the API updates on follow-up patches. For instance, I'd love us to start using latest Robotium in the new API (bug 910791).

Comment 7

[Geoff Brown [:gbrown]]

(In reply to Chenxia Liu [:liuche] from comment #5)
> (Link to try push here: https://tbpl.mozilla.org/?tree=Try&rev=067dec621504)

Careful - there's a robocop-3 on Android 4.0 now (not in the try push).

Comment 8

[Chenxia Liu [:liuche]]

Thanks Geoff, I've made a new try push here: https://tbpl.mozilla.org/?tree=Try&rev=a50827a3f9d6

Do you know who I should talk to to include robocop-3 in the trychooser?

Comment 9

[:Margaret Leibovic]

(In reply to Chenxia Liu [:liuche] from comment #8)
> Thanks Geoff, I've made a new try push here:
> https://tbpl.mozilla.org/?tree=Try&rev=a50827a3f9d6
> 
> Do you know who I should talk to to include robocop-3 in the trychooser?

I know Lukas worked on this in the past, maybe she knows who to talk to about it now.

Comment 10

[Geoff Brown [:gbrown]]

(In reply to Chenxia Liu [:liuche] from comment #8)
> Do you know who I should talk to to include robocop-3 in the trychooser?

I would file a bug similar to bug 893733.

Comment 11

[Chenxia Liu [:liuche]]

All green w/ r3 tests run as well.

Comment 12

[Chenxia Liu [:liuche]]

(In reply to Geoff Brown [:gbrown] from comment #10)
> (In reply to Chenxia Liu [:liuche] from comment #8)
> > Do you know who I should talk to to include robocop-3 in the trychooser?
> 
> I would file a bug similar to bug 893733.

Thanks Geoff! Filed bug 911907 and cc-ed you on it.

Comment 13

[Geoff Brown [:gbrown]]

Comment on attachment 798029 [details] [diff] [review]
Patch: upgrade to robotium-4.2 v2

Review of attachment 798029 [details] [diff] [review]:
-----------------------------------------------------------------

This looks great.


The attached patch is showing:

   Deleted Binary File: build/mobile/robocop/robotium-solo-3.6.jar
   New Binary File: build/mobile/robocop/robotium-solo-4.1.jar

Note the 4.1 rather than 4.2. The latest try push definitely has 4.2. I'm not sure where the confusion is, but please double-check that you are checking-in the 4.2 jar.

Comment 14

[Chenxia Liu [:liuche]]

Attachment: Patch: upgrade to robotium-4.2 v3

Uploaded a new patch w/ robotium 4.2, not sure what happened with the obsolete one.

Comment 15

[Chenxia Liu [:liuche]]

https://hg.mozilla.org/integration/fx-team/rev/8c04d40e218d

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8c04d40e218d

Comment 17

[Adrian Tamas (:AdrianT)]

(In reply to Chenxia Liu [:liuche] from comment #3)
> Created attachment 798029 [details] [diff] [review]
> Patch: upgrade to robotium-4.2 v2
> 
> Didn't see comment #2, added those changes. Initial try push here:
> https://tbpl.mozilla.org/?tree=Try&rev=364b95b737b8
> 
> Adrian: are there any other places that you've made notes to change when
> updating the robotium jar?
Just what you removed from Actions and FennecNativeActions since none of the patches that used clickLongOnScreen was used.