908745 - Add tests for the changes from bugs 872195, 899326 & 899770

Status: RESOLVED FIXED

(Calendar :: ICAL.js Integration, enhancement)

Description

[Markus Adrario [:Taraman]]

The mentioned bugs have been fixed upstream in ical.js

Nevertheless, the tests are written and should go into calendar tests as well.

This bug will take care.

Comment 1

[Markus Adrario [:Taraman]]

Attachment: add tests V1

Comment 2

[Markus Adrario [:Taraman]]

Attachment: enable-icaljs-testing for xpcshell-tests

this is a small patch, that sets ical.js as backend for the xpcshell-tests to help run these tests with it.

Comment 3

[Martin Schröder [:mschroeder]]

Markus, do you also plan to update ical.js in Lightning?

Comment 4

[Markus Adrario [:Taraman]]

As I understood, the current ical.js version is transferred into lightning on a regular basis.
I already asked philipp, how this works and when these fixes will be incorporated, but he is very busy with his exams, so it may take a while, until I get an answer.

But - Yes, I plan to.

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 794768 [details] [diff] [review]
add tests V1

r=philipp for the tests. I noticed you added added some lines to work around the missing addTimezoneReference in the enabler patch, I have a patch that fixes this bug. addTimezoneReference is being called on the wrong object.

Comment 6

[Markus Adrario [:Taraman]]

> r=philipp for the tests. I noticed you added added some lines to work around
> the missing addTimezoneReference in the enabler patch, I have a patch that
> fixes this bug. addTimezoneReference is being called on the wrong object.

:-o
I can't even remember to have written these lines. I don't know, where these come from!?!?
So what do you think, should we leave it as is, until you have inished your patch?

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

Pushing attachment 794768 [details] [diff] [review] is fine as is, which is the intent of this bug. I was just commenting on attachment 794769 [details] [diff] [review], which I will be fixing with bug 973651.

Comment 8

[Markus Adrario [:Taraman]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/0e575a37a7f5>

-> FIXED