908813 - OdinMonkey: Differential Testing: Different error message involving --ion-eager

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

try {
    (function() {
        e(function() {
            {
                "use asm"
            }
        })
    })()
} catch (e) {}


shows the following on a 32-bit debug deterministic threadsafe js shell on m-c rev fb2318875cd4 with --ion-eager:

1comparejit.js:5:16 warning: "use asm" is only meaningful in the Directive Prologue of a function body:
1comparejit.js:5:16 warning:                 "use asm"
1comparejit.js:5:16 warning: ................^
1comparejit.js:5:16 warning: "use asm" is only meaningful in the Directive Prologue of a function body:
1comparejit.js:5:16 warning:                 "use asm"
1comparejit.js:5:16 warning: ................^

but shows the following without any CLI arguments:

1comparejit.js:5:16 warning: "use asm" is only meaningful in the Directive Prologue of a function body:
1comparejit.js:5:16 warning:                 "use asm"
1comparejit.js:5:16 warning: ................^

(Pass in the testcase as a CLI argument to reproduce)

There is an extra copy of the warning. Is this intended?

Comment 1

[Luke Wagner [:luke]]

Attachment: fix-warning

Oh, haha, we report the warning once during the syntax-only parse and again during the full parse.  Probably doesn't matter, but trivial to fix.

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 794820 [details] [diff] [review]
fix-warning

Review of attachment 794820 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch!

Comment 3

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/143b76709fab

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/143b76709fab