908837 - Include a bit less stuff in binding implementation files

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

We can drop nsContentUtils and lots of binding headers we aren't actually using: we only need binding headers for some of our ancestor interfaces, not for all interfaces we have as args or whatnot.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Include a bit less stuff in binding implementation files.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 794822 [details] [diff] [review]
Include a bit less stuff in binding implementation files.


>         for iface in interfaceDeps:
>-            while iface.parent:
>+            if iface.parent:
>+                # We're going to need its prototype
>                 ancestors.append(iface.parent)
>-                iface = iface.parent
>+                # And if we have an interface object, we'll need the
>+                # nearest ancestor with an interface object too.
please explain why


>+                if iface.hasInterfaceObject():
Shouldn't this be 
if iface.hasInterfaceObject() and not iface.parent.hasInterfaceObject():

r+ assuming this compiles :)

Comment 3

[Boris Zbarsky [:bzbarsky]]

> Shouldn't this be 
> if iface.hasInterfaceObject() and not iface.parent.hasInterfaceObject():

Doesn't matter, since we're just adding to a set, so adding iface.parent twice isn't going to hurt anything.

Comment 4

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/18311b19cd53

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/18311b19cd53