Closed
Bug 908846
Opened 11 years ago
Closed 11 years ago
Add New Wallpapers for 1.2 for Tablet
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(b2g18+)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
b2g18 | + | --- |
People
(Reporter: padamczyk, Assigned: GaryChen)
References
Details
(Whiteboard: visual design, visual-tracking, sverd)
Attachments
(2 files, 1 obsolete file)
Sean Martell with attach the wallpapers from Brand I will attach the photographic wallpapers. They need to be provided only in Landscape form, 1280x800
Reporter | ||
Updated•11 years ago
|
Flags: needinfo?(smartell)
Flags: needinfo?(padamczyk)
Reporter | ||
Updated•11 years ago
|
Reporter | ||
Comment 1•11 years ago
|
||
All other wallpapers not included in this bug should be removed from the tablet. Please make "grassy_field" the default.
Flags: needinfo?(padamczyk)
Reporter | ||
Comment 2•11 years ago
|
||
1. Added "L" to the file name to signify Landscape version 2. All other wallpapers not in this attachment should be removed from the tablet 3. Please name "Grassy Field" default
Attachment #799771 -
Attachment is obsolete: true
Comment 3•11 years ago
|
||
Files can be found here: http://people.mozilla.org/~smartell/fxos/fxos-branded-wallpapers-TABLET.zip Enjoy!
Flags: needinfo?(smartell)
Updated•11 years ago
|
Flags: needinfo?(itsay)
Assignee | ||
Comment 4•11 years ago
|
||
Hi Sean, I saw current wallpaper images format are PNG, Can you provide PNG format please. https://github.com/mozilla-b2g/gaia/pull/12051/files
Flags: needinfo?(itsay) → needinfo?(smartell)
Comment 5•11 years ago
|
||
will fix this in bug 911689 (tablet distribution)
Comment 6•11 years ago
|
||
Gary, if you are interested, welcome to provide PR to https://github.com/mozilla-b2g/gaia/pull/12051/files
Flags: needinfo?(gchen)
Assignee | ||
Comment 7•11 years ago
|
||
(In reply to Fred Lin [:gasolin] from comment #6) > Gary, if you are interested, welcome to provide PR to > https://github.com/mozilla-b2g/gaia/pull/12051/files okay, I will send the PR after your patch landing in master.
Flags: needinfo?(gchen)
Assignee | ||
Comment 8•11 years ago
|
||
(In reply to Sean Martell from comment #3) > Files can be found here: > http://people.mozilla.org/~smartell/fxos/fxos-branded-wallpapers-TABLET.zip > > Enjoy! Sorry, I can't access this file, please check it again. thanks.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → gchen
Flags: needinfo?(smartell)
Comment 9•11 years ago
|
||
figured out the link :) http://people.mozilla.org/~smartell/fxos/fxos-branded-wallpapers-WVGA.zip
Flags: needinfo?(gchen)
Assignee | ||
Comment 11•11 years ago
|
||
(In reply to Eric Pang [:epang] from comment #9) > figured out the link :) > http://people.mozilla.org/~smartell/fxos/fxos-branded-wallpapers-WVGA.zip Hi Eric, I found all the images in this zip are 480x800, seems we need 1280*800. Can you check this again?
Flags: needinfo?(epang)
Comment 12•11 years ago
|
||
(In reply to GaryChen [:GaryChen] from comment #11) > (In reply to Eric Pang [:epang] from comment #9) > > figured out the link :) > > http://people.mozilla.org/~smartell/fxos/fxos-branded-wallpapers-WVGA.zip > > Hi Eric, > I found all the images in this zip are 480x800, seems we need 1280*800. > Can you check this again? Hi Gary, would the wallpapers be to wide then? The screen size is only 480x800? Do you have an example of an exiting wallpaper that's at this size?
Flags: needinfo?(epang)
Comment 13•11 years ago
|
||
Gary, here's the correct link. I was thinking that tablet was wvga, sorry about that! http://people.mozilla.org/~smartell/fxos/fxos-branded-wallpaper-TABLET.zip
Assignee | ||
Comment 14•11 years ago
|
||
Attachment #803544 -
Flags: review?(gasolin)
Comment 15•11 years ago
|
||
I've test on nighly, it works fine. Will try in real device once available.
Comment 16•11 years ago
|
||
Comment on attachment 803544 [details] pull request: https://github.com/mozilla-b2g/gaia/pull/12144 looks good to me on real device. But I found wallpaper/gallery picker is not work either on previous or this patch. We have to do the following work to able to pick wallpapers.
Attachment #803544 -
Flags: review?(gasolin) → review+
Comment 17•11 years ago
|
||
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/2257367510f87474159317ca3d9c59ee1835df05 thanks!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•