90888 - Wrong key shortcut in Go->Home menu.

Status: VERIFIED FIXED

(Core :: Internationalization: Localization, defect)

Description

[Marek Wawoczny]

On localized mozilla there is bug with key shortcut in Go->Home menu. On
previous relases it was "Alt+Home" on localized mozilla is "Alt"+ localized name
of home label. On screenshoot english "Home" = polish "Dom" and access key is
"Alt+Dom" it should be "Alt+Home", because there is no "Dom" key on qwerty
keybords, there is only "Home" key. On previous relases everything was ok.

Comment 1

[Marek Wawoczny]

Attachment: Wrong key shortcut screenshoot

Comment 2

[timeless]

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpfe/browser/resources/loca
le/en-US/navigator.dtd
I guess we need a localization note?

Comment 3

[:deanis74]

Wrong file.  The description of VK_HOME is at

http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/locale/en-US/keys.properties#28

Comment 4

[Marek Wawoczny]

Ok, make localization note for that file. Find&Replace is not always good for 
making localized files ;))) Marking as Invalid.

Comment 5

[timeless]

um. i'd prefer to leave this bug open since there was no indication to a 
translator hinting _not_ to do this.

Comment 6

[timeless]

jag owns the file...

Comment 7

[timeless]

Attachment: proposal. not necessarily in-line w/ l10n stds ...

Comment 8

[jag (Peter Annema)]

Proposal: Add a note for l10n that these labels are the names of the keys on
keyboards, and they should translate this file based on what kind of keyboard is
prevalent for their target group.

Comment 9

[Bradley Hart]

Marking new, not sure why this is _not_ marked new yet...

Comment 10

[Andreas Becker]

mass change, switching qa contact from jonrubin to ruixu.

Comment 11

[elaineking]

removed keyword nsbranch since bug now has nsbranch-, per pdt mtg.

Comment 12

[jag (Peter Annema)]

-> timeless

Timeless, perhaps consult with the l10n team to see what's the best comment up 
there? I guess I would go with something as simple as "these labels represent 
the text on the keys on a keyboard, localize as appropriate".

Comment 13

[timeless]

Ok, um, comments from the l10n team?

Comment 14

[rchen]

Not all the translators know what "VK_" stands for.  I have seen VK_HOME="Home" 
translated as the address "home" in some case. So both Timeless's attachment and 
Peter's proposal are necessary. Thank you, guys.

Comment 15

[jag (Peter Annema)]

Maybe for completeness add a BLOCK end for that last block. sr=jag

Comment 16

[timeless]

ok i checked in a fix for this based on my patch and jag and rchen's comments. if people want things changed feel free to reopen this bug with suggestions.

Comment 17

[:deanis74]

It looks pretty good to me.  It's definitely better than what was there, and the
changes probably go beyond the scope of the bug.

Comment 18

[Rui Xu]

Verify fixed with Mozilla build 2001122106 (0.9.7).