908883 - Video Play Event is not working on Original Firstrun Page

Status: VERIFIED FIXED

(www.mozilla.org :: Analytics, defect, P3)

Description

[Gareth Cull [:garethc]]

For some reason, the video play event is not working any more on the original firstrun page. Can we please review this? 

Pause and Finish event actions are working, so something must have broken. Thanks.

https://www.mozilla.org/en-US/firefox/24.0/firstrun/

Comment 1

[Chris More [:cmore]]

Note: The video is working, it is only the custom GA events and specifically the play event that is not being sent to GA.

Comment 2

[Chris More [:cmore]]

Can we get this resolved before we run the A/B ADI test for firstrun?

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/77cfdead8c6e1e7e6c0f07ce48762e007620bcfa
Fix & refactor GA video tracking on fx firstrun. Bug 908883.

https://github.com/mozilla/bedrock/commit/5f4d0a525429f7e3a3b96a55789302abec513aab
Merge pull request #1190 from jpetto/bug-908883-fx-firstrun-video-play-ga

Fix & refactor GA video tracking on fx firstrun. Bug 908883.

Comment 4

[raymond [:retornam] (inactive)]

fixed on stage https://www.allizom.org/en-US/firefox/24.0/firstrun/

Gareth can you confirm that this is working in GA?

Comment 5

[Gareth Cull [:garethc]]

Confirmed. I'm seeing this data now flow into GA. 

Here's a screencap of Real-time "play" data coming into our allizom.org GA profile: 
http://cl.ly/image/241T1Z2d072R

Thanks for the fix! Can we please push this to prod? Thanks.

Comment 6

[raymond [:retornam] (inactive)]

This has already been pushed to prod. Please confirm prod data so we can mark this bug as fixed. Thanks

Comment 7

[Gareth Cull [:garethc]]

Confirmed. I'm seeing "play" data now appear in production. Thanks!

Comment 8

[raymond [:retornam] (inactive)]

closing per comment #7