908886 - [Android] App purchase fails with [JavaScript Error: "[payments] `navigator.mozPay` error: PAY_REQUEST_ERROR_NO_VALID_REQUEST_FOUND"]

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Launch marketplace-dev on nightly(26.0a1) on your android phone
2. Start the purchase of an app
3. Sign in to your Persona account

expected behavior:
Webpay loads the Enter PIN screen

observed behavior:
Payment flow is aborted with the Payment cancelled user message

logcat shows:
 08-23 14:29:52.485 E/GeckoConsole( 5582): [JavaScript Error: "[payments] `navigator.mozPay` error: PAY_REQUEST_ERROR_NO_VALID_REQUEST_FOUND"]

logs:
08-23 14:29:52.070 E/GeckoConsole( 5582): [model] Found app with lookup key test-app-y7430
08-23 14:29:52.070 E/GeckoConsole( 5582): [buttons] Install requested for Test App (y7430)
08-23 14:29:52.075 E/GeckoConsole( 5582): [JavaScript Warning: "[buttons] User data not available for Test App (y7430)"]
08-23 14:29:52.075 E/GeckoConsole( 5582): [buttons] Starting payment flow for Test App (y7430)
08-23 14:29:52.080 E/GeckoConsole( 5582): [payments] Initiating transaction
08-23 14:29:52.080 E/GeckoConsole( 5582): [req] POSTing https://marketplace-dev.allizom.org/api/v1/webpay/prepare/?_user=krupa.mozbugs%40gmail.com%2C88b31cca5ae8e065ed3051c5dca74a410df9ed680236e9bf0a6f21d5fb687646a6f4c706d9ad78e34c67b3b3e13cb1bb9c68b034cf084771ec8aad4ec545093a%2Cec8af083e8174d3cbedd7c62dcbad132&dev=android&device=mobile&lang=en-US&pro=eab553fc.32.1&region=us
08-23 14:29:52.340 D/PowerManagerService( 1978): onSensorChanged: light value: 100
08-23 14:29:52.480 E/GeckoConsole( 5582): [req] POSTed https://marketplace-dev.allizom.org/api/v1/webpay/prepare/?_user=blahblah&dev=android&device=mobile&lang=en-US&pro=eab553fc.32.1&region=us
08-23 14:29:52.480 E/GeckoConsole( 5582): [payments] Calling mozPay with JWT:  eyJhbGciOiAiSFMyNTYiLCAidHlwIjogIkpXVCJ9.eyJhdWQiOiAibWFya2V0cGxhY2UtZGV2LmFsbGl6b20ub3JnIiwgImlzcyI6ICJtYXJrZXRwbGFjZS1kZXYuYWxsaXpvbS5vcmciLCAicmVxdWVzdCI6IHsibmFtZSI6ICJUZXN0IEFwcCAoeTc0MzApIiwgImNoYXJnZWJhY2tVUkwiOiAiaHR0cHM6Ly9tYXJrZXRwbGFjZS1kZXYuYWxsaXpvbS5vcmcvc2VydmljZXMvd2VicGF5L2NoYXJnZWJhY2siLCAicHJvZHVjdERhdGEiOiAiYWRkb25faWQ9NDQyNTgxJmFwcGxpY2F0aW9uX3NpemU9NDE5JnNlbGxlcl91dWlkPWI2ZWRkNjI5LTlhNzUtNGQwZi1hZTRkLTUyMGI2MTNkYmE3MyZjb250cmliX3V1aWQ9YjQ2NWZlYjg0YjAyZDc4MDdkNjY5NjM0ZTIyYTEyMDkiLCAicHJpY2VQb2ludCI6ICIxMCIsICJpY29ucyI6IHsiNDgiOiAiaHR0cHM6Ly9tYXJrZXRwbGFjZS1kZXYtY2RuLmFsbGl6b20ub3JnL2ltZy91cGxvYWRzL2FkZG9uX2ljb25zLzQ0Mi80NDI1ODEtNDgucG5nP21vZGlmaWVkPTEzNzcyODU2MzgiLCAiMzIiOiAiaHR0cHM6Ly9tYXJrZXRwbGFjZS1kZXYtY2RuLmFsbGl6b20ub3JnL2ltZy91cGxvYWRzL2FkZG9uX2ljb25zLzQ0Mi80NDI1ODEtMzIucG5nP21vZGlmaWVkPTEzNzcyODU2MzgiLCAiNjQiOiAiaHR0cHM6Ly9tYXJrZXRwbGFjZS1kZXYtY2RuLmFsbGl6b20ub3JnL2ltZy91cGxvYWRzL2FkZG9uX2ljb25zLzQ0Mi80NDI1ODEtNjQucG5nP21vZGlmaWVkPTEzNzcyODU2M
08-23 14:29:52.485 E/GeckoConsole( 5582): [JavaScript Error: "[payments] `navigator.mozPay` error: PAY_REQUEST_ERROR_NO_VALID_REQUEST_FOUND"]
08-23 14:29:52.485 E/GeckoConsole( 5582): [buttons] Purchase flow rejected for Test App (y7430)
08-23 14:29:52.485 E/GeckoConsole( 5582): [buttons] Unsuccessful install for Test App (y7430)

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Wes - does this sound like a problem with Persona on Fennec, which would point to bug 826325 ?

Comment 2

[Kumar McMillan [:kumar]]

This error means that the device is not configured with proper settings. Marketplace dev needs these settings in order for payments to work on device: https://github.com/mozilla/webpay/blob/master/ezboot/custom-prefs.js

Comment 3

[Kumar McMillan [:kumar]]

How should we add custom settings on Android? Do we need to make a custom build? On Firefox OS we use `adb push` to put a settings file in /data/local

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

I think you need to add them to https://mxr.mozilla.org/mozilla-central/source/mobile/android/app/mobile.js#748

Wesley can probably confirm it.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Kumar McMillan [:kumar] from comment #3)
> How should we add custom settings on Android? Do we need to make a custom
> build? On Firefox OS we use `adb push` to put a settings file in /data/local

about:config is your friend. You should be able to tweak the settings that ship on Nightly using about:config.

Comment 6

[Kumar McMillan [:kumar]]

(In reply to Mark Finkle (:mfinkle) from comment #5)
> about:config is your friend. You should be able to tweak the settings that
> ship on Nightly using about:config.

Heh, that sounds painful to type on an Android device. There are about 15 prefs needed. So the alternative is to make a custom build with prefs added here? https://mxr.mozilla.org/mozilla-central/source/mobile/android/app/mobile.js#748

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Kumar McMillan [:kumar] from comment #6)
> (In reply to Mark Finkle (:mfinkle) from comment #5)
> > about:config is your friend. You should be able to tweak the settings that
> > ship on Nightly using about:config.
> 
> Heh, that sounds painful to type on an Android device. There are about 15
> prefs needed. So the alternative is to make a custom build with prefs added
> here?
> https://mxr.mozilla.org/mozilla-central/source/mobile/android/app/mobile.
> js#748

Correct. I guess an add-on could work too. Which ever is easiest for you.

Comment 8

[Kumar McMillan [:kumar]]

Ah, a custom add-on sounds like the easiest solution

Comment 9

[Wesley Johnston (:wesj)]

Attachment: Devprefs.xpi

Extension to set the dev prefs.

Comment 10

[Andy McKay]

I altered it locally to support desktop, installed it and got a pile of prefs. Should probably get the source on github and the addon on AMO.

That's great, thanks, really helpful.

Comment 11

[Wesley Johnston (:wesj)]

https://github.com/wesj/devMarketplace and
https://addons.mozilla.org/en-US/firefox/addon/dev-marketplace/

Comment 12

[Kumar McMillan [:kumar]]

Wes, you are most righteous! Thanks for this add-on. This enables payment prefs but it looks like the Persona login is not working, I filed bug 914415 for that. Making progress...

Comment 13

[Wesley Johnston (:wesj)]

That is likely a dup of bug 826325. I'll land those patches on inbound tonight!