908944 - Add utility for stuffing messages into inbox for integration tests

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P4)

Description

[James Lal [:lightsofapollo]]

We need this to correctly test some things where sending an email from the ui to the ui is not enough.

Comment 1

[James Lal [:lightsofapollo]]

Per my discussion with asuth:

for imap:

- extract out messageGenerator.js to its own repo
- APPEND messages to the imap server
- try to refactor reuse as much as possible as GELAM 
- probably needs to be in tree (gaia)

Comment 2

[Mike Lee [:mlee]]

Andrew/James,

Is anyone actively working on this or is there a plan for when someone will work on this?

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Not actively being worked yet; probably will get worked soon as some of the more complex e-mail periodic sync integration tests will likely require the changes.  Experience-wise, myself or James Lal are the best choices, but time/dependency-wise it will probably fall to James Burke who is the one actually implementing those integration tests (and who will then have the experience! :)  Time-frame for that would probably be sometime next week, but maybe another week depending on what blockers come up.

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

Maybe with some support from Andrew I could give this one a shot?

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

Indeed; great further e-mail ramp-up bug for you.  I don't think my mind grokked that the share bug was done!

Basically, we want to extract the path done by do_addMessagesToFolder in th_main.js and add a little more of a friendly shim around the message definition, I think.  Right now you either define a set descriptor or provide a function that creates a list of messages.  We probably also want to also accept an array of message creation descriptors that the messageGenerator.js likes.

Then we use the th_fake_imap_server.js-type stuff to tell the IMAP server to insert the messages in, just like we do in the e-mail back-end tests.  (It is what actually does the APPEND).

We do want maximum overlap, so migrating things out of GELAM into mail-fakeservers or some other repo is good so that the GELAM tests still use the same logic.  I need to finish packing for work travel right now and will be incommunicado today and tomorrow, but I discussed this pretty in-depth with James Lal, so hopefully he can help provide guidance.

Comment 6

[bhavana bajaj [:bajaj]]

Discussed in triage, that is not a blocker but we may uplift it depending on when in cycle we have the test.

Comment 7

[BMO Automation]

Firefox OS is not being worked on