909005 - use getdents() on OpenBSD in ipc dir_reader_bsd

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Landry Breuil (:gaston)]

Attachment: Use getdents() on OpenBSD too

OpenBSD got the 'standard' getdents() API in place of getdirentries() in http://marc.info/?l=openbsd-cvs&m=137637321205010&w=2 and http://marc.info/?l=openbsd-cvs&m=137664242330561&w=2 so let's remove the special case in ipc/chromium/src/base/dir_reader_bsd.h

Comment 1

[Mike Hommey [:glandium]]

Comment on attachment 795040 [details]
Use getdents() on OpenBSD too

Shouldn't you do a version check instead? The support for getdents you're pointing to is 2 weeks old!

Comment 2

[Landry Breuil (:gaston)]

That cvs commit was an abi break anyway (old binaries wont run with newer libc/kernel), and we cant really do a libc version check.. besides checking for getdents() presence (or getdirentries(), depends on which side we want to be) and adding more #ifdefs, i dont see a way.

We only support -current ports on a -current system, and we already have the patch in the port for firefox 23.0.

Basically, i'm the only one possibly affected by this, and i'm slowly moving all my systems past the 64-bits time_t bump, so i will need this commit on all my builders that have crossed the jump.

Comment 3

[Mike Hommey [:glandium]]

What about the people running a system without those libc/kernel changes, and building mozilla-central themselves?

Comment 4

[Landry Breuil (:gaston)]

(In reply to Mike Hommey [:glandium] from comment #3)
> What about the people running a system without those libc/kernel changes,
> and building mozilla-central themselves?

I honestly dont think anyone besides me does that (on OpenBSD).

But if you really really want it, i can go through the AC_CHECK_FUNCS(getdirentries) route in configure.in and pass the corresponding configure hell flag all the way through ipc... and let the resulting ifdef bitrot in the tree for 5 years.

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 795040 [details]
Use getdents() on OpenBSD too

Ok, then. (Note I'm not a peer, but i don't think it's a problem for this patch)

Comment 6

[Landry Breuil (:gaston)]

All my builders crossed the ABI break, so now is a good time to push this..

https://hg.mozilla.org/integration/mozilla-inbound/rev/66991961691d

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/66991961691d