909139 - GeckoProfiler.h:103:55: error: unknown type name 'uint32_t' (non-SPS)

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Jan Beich]

On platforms without SPS profiler the build is broken due to standard
types not being defined as there're no std* headers included before.
Up until bug 907798 uint* types were pulled via Assertions.h->stddef.h.

In file included from toolkit/xre/EventTracer.cpp:51:
dist/include/GeckoProfiler.h:103:55: error: unknown type name 'uint32_t'
                              const char** aFeatures, uint32_t aFeatureCount,
                                                      ^
dist/include/GeckoProfiler.h:104:64: error: unknown type name 'uint32_t'
                              const char** aThreadNameFilters, uint32_t aFil...
                                                               ^

Comment 1

[Landry Breuil (:gaston)]

This is getting... boring. Cant a TBPL job actually check for builds WITHOUT the profiler ?

Comment 2

[Jan Beich]

Attachment: add include

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 795184 [details] [diff] [review]
add include

Review of attachment 795184 [details] [diff] [review]:
-----------------------------------------------------------------

Sigh. Ship it.

Comment 4

[Landry Breuil (:gaston)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/01bc0e5c528f

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/01bc0e5c528f