Closed Bug 909274 Opened 8 years ago Closed 8 years ago

Unable to scroll through search engines

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect)

Other
Android
defect
Not set
normal

Tracking

(fennec25+)

RESOLVED FIXED
Firefox 26
Tracking Status
fennec 25+ ---

People

(Reporter: kats, Assigned: mcomella)

References

Details

(Keywords: regression)

Attachments

(1 file)

On a galaxy Q in landscape mode (small screen height) and search suggestions disabled:

1. add a custom search engine (i have ones for bugzilla and mxr)
2. Open the awesomescreen and start typing a search term

Expected: able to scroll down to my custom search engines and do the search on them.

Actual: the 4 default search providers are shown in the space below (taking up all the available screen space) and I cannot scroll to reveal my custom search engines.

Presumably this is a fig regression.
tracking-fennec: --- → ?
Keywords: regression
It seems the history results allow scrolling, while the search providers do not.

I had a similar issue for getting the keyboard to dismiss when scrolled so I'll take a look at it.
Assignee: nobody → michael.l.comella
Status: NEW → ASSIGNED
Note to self: Add a regression test for this.
Attached patch 01: PatchSplinter Review
I'll be adding some regression tests in another patch.
Attachment #796885 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 796885 [details] [diff] [review]
01: Patch

Review of attachment 796885 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/home/BrowserSearch.java
@@ +881,5 @@
>                  // Dismiss the soft keyboard.
>                  requestFocus();
>              }
>  
> +            return super.onInterceptTouchEvent(event);

Nice catch.
Attachment #796885 - Flags: review?(lucasr.at.mozilla) → review+
tracking-fennec: ? → 25+
https://hg.mozilla.org/mozilla-central/rev/1ea0bdb2357d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.