909274 - Unable to scroll through search engines

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

On a galaxy Q in landscape mode (small screen height) and search suggestions disabled:

1. add a custom search engine (i have ones for bugzilla and mxr)
2. Open the awesomescreen and start typing a search term

Expected: able to scroll down to my custom search engines and do the search on them.

Actual: the 4 default search providers are shown in the space below (taking up all the available screen space) and I cannot scroll to reveal my custom search engines.

Presumably this is a fig regression.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

It seems the history results allow scrolling, while the search providers do not.

I had a similar issue for getting the keyboard to dismiss when scrolled so I'll take a look at it.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Note to self: Add a regression test for this.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Attachment: 01: Patch

I'll be adding some regression tests in another patch.

Comment 4

[Lucas Rocha (:lucasr)]

Comment on attachment 796885 [details] [diff] [review]
01: Patch

Review of attachment 796885 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/home/BrowserSearch.java
@@ +881,5 @@
>                  // Dismiss the soft keyboard.
>                  requestFocus();
>              }
>  
> +            return super.onInterceptTouchEvent(event);

Nice catch.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/1ea0bdb2357d

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1ea0bdb2357d