If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Better document scrollbar type conversion in RecordFrameMetrics

RESOLVED FIXED in mozilla26

Status

()

Core
Layout
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

26 Branch
mozilla26
Other
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

See bug 907495 comment 4. This is a follow-up bug to do the second thing suggested in that comment (add a helper to CSSPixel and make the conversion explicit). As Ms2ger said in bug 907495 comment 9, the code as it is looks fishy now.
Assignee: nobody → bugmail.mozilla
Created attachment 796721 [details] [diff] [review]
Patch

This applies on top of the patch from bug 904533
Bug 904533 is changing this code somewhat. I'll revisit this once that lands.
Depends on: 904533
Created attachment 802550 [details] [diff] [review]
Add some margin operators

Pretty straightforward extension of the existing code.
Attachment #796721 - Attachment is obsolete: true
Attachment #802550 - Flags: review?(bgirard)

Updated

4 years ago
Attachment #802550 - Flags: review?(bgirard) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a84c41a86bc4
https://hg.mozilla.org/mozilla-central/rev/a84c41a86bc4
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.