909283 - "System JS : WARNING /builds/slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_cache_jar.js:51 yield without a value is deprecated, and illegal in ES6 (use 'yield undefined' instead)" in xpcshell runs

Status: RESOLVED FIXED

(Core :: Networking: JAR, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=26945334&tree=Mozilla-Central

Ubuntu VM 12.04 mozilla-central debug test xpcshell on 2013-08-23 15:33:01 PDT for push 6dea0e001df0
slave: tst-linux32-ec2-048

15:52:05     INFO -  System JS : WARNING /builds/slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_cache_jar.js:51
15:52:05     INFO -                       yield without a value is deprecated, and illegal in ES6 (use 'yield undefined' instead)
15:52:05     INFO -  System JS : WARNING /builds/slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_cache_jar.js:71
15:52:05     INFO -                       yield without a value is deprecated, and illegal in ES6 (use 'yield undefined' instead)
15:52:05     INFO -  System JS : WARNING /builds/slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_cache_jar.js:85
15:52:05     INFO -                       yield without a value is deprecated, and illegal in ES6 (use 'yield undefined' instead)

Comment 1

[Andy Wingo [:wingo]]

This warning was introduced in bug 885463 by jorendorff and Waldo.  The solution here is for an owner of this code to change to "yield undefined".  (I don't find the warning terribly helpful given the other differences in ES6, but whatever :)

Comment 2

[Sahil Chelaramani]

Attachment: changed yield; to yield undefined

I think this should work.jdm please review!

Comment 3

[Josh Matthews [:jdm]]

Comment on attachment 798028 [details] [diff] [review]
changed yield; to yield undefined

Can you fix the others in this file as well?

Comment 4

[Josh Matthews [:jdm]]

Also, please write a commit message for the patch that describes the change; the bug's summary is not very informative.

Comment 5

[Sahil Chelaramani]

Attachment: changed all occurances of yield; to yield undefined

Thanks for the feedback! I made the changes you asked for. Here is the new patch. Please review.

Comment 6

[Sahil Chelaramani]

Attachment: changed all occurances of yield; to yield undefined

Improved the commit message.

Comment 7

[Josh Matthews [:jdm]]

Comment on attachment 798116 [details] [diff] [review]
changed all occurances of yield; to yield undefined

Excellent. Thanks!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3287472e22f4

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3287472e22f4

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/91e513122ea5