909330 - "uniqtabs" add-on simple-pref labels are broken

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Mitchell Field [:Mitch]]

Steps To Reproduce:
1. Install https://addons.mozilla.org/en-us/firefox/addon/uniqtabs/
2. Go to the add-on's options in Add-ons Manager.

Actual Results:
Localised string values are absent for integer pref labels. Keys are shown instead of values for radio button labels.

Expected Results:
Preferences specified in the add-on's package.json should have their corresponding labels in the preferences UI.

Regression window (mozilla-central)
Good:
http://hg.mozilla.org/mozilla-central/rev/d136c8999d96
ID:20130821030213
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 
Bad:
http://hg.mozilla.org/mozilla-central/rev/2ab07dec6404
ID:20130822030204
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d136c8999d96&tochange=2ab07dec6404

Comment 1

[Mitchell Field [:Mitch]]

I did a bit of digging with SDK version 1.14 and the latest revision (https://github.com/mozilla/addon-sdk/commit/2e78984ce0f3b7cf4df1a5977491e4e0df9a992c).

Add-on SDK version ended up being irrelevant. "cfx run --strip" in the uniqtabs source dir, configured to run the "bad" Firefox build above contained the following:

Plural form unknown for locale "null"

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I reverted bug 865391 locally and your preference names showed up.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

If you can test your addon against the current Github master branch to make sure that revert works as expected, that'd be great. It seems to work for me.

The command to run your addon would be: 
cfx run -b /path/to/nightly -o

This will override the version of the SDK shipped with Firefox with the github version.

Comment 4

[Mitchell Field [:Mitch]]

(In reply to Wes Kocher (:KWierso) from comment #3)
> If you can test your addon against the current Github master branch to make
> sure that revert works as expected, that'd be great. It seems to work for me.
> 
> The command to run your addon would be: 
> cfx run -b /path/to/nightly -o
> 
> This will override the version of the SDK shipped with Firefox with the
> github version.

That works as expected.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

A final test would be to download and extract this zipped version of Firefox (assuming you're on Windows): http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/fx-team-win32/1377530304/firefox-26.0a1.en-US.win32.zip

And then the command to test it would be:
cfx run -b path/to/that/unzipped/firefox.exe

Since this doesn't include the -o flag, it will use the now-hopefully-fixed version of the SDK bundled in Firefox itself.

If everything works there, then the fix for this bug will make its way into either tonight's or tomorrow night's official Nightly build as the code gets merged into mozilla-central.

Comment 6

[Mitchell Field [:Mitch]]

(In reply to Wes Kocher (:KWierso) from comment #5)
> ...

Yes, that all seems to work.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Marking fixed by the revert.