909340 - Hide XULElement from content

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Part 1: Introduce a struct containing protoIfaceArray

mDefined will be used in following patches.

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: Part 2: Decouple defining interface objects from the creation

Without this patch, aDefineOnGlobal will be effectively ignored if GetProtoObject is called before GetConstructorObject. And it is unpredictable when GetConstructorObject is called because GlobalResolve calls it lazily.

Comment 3

[Masatoshi Kimura [:emk]]

Attachment: Part 3: Stop defining interface objects in GetProtoObject

Comment 4

[Masatoshi Kimura [:emk]]

https://tbpl.mozilla.org/?tree=Try&rev=a02d749e5803

Comment 5

[Boris Zbarsky [:bzbarsky]]

I'm not sure what I think of the additional complexity....  Peter?

Comment 6

[Masatoshi Kimura [:emk]]

Attachment: Alternative patch

This is a bit more ad hoc, but much simpler.

Comment 7

[Masatoshi Kimura [:emk]]

https://tbpl.mozilla.org/?tree=Try&rev=abcad28039bf

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 796714 [details] [diff] [review]
Alternative patch

r=me.

If we ever need this for other interfaces, we can worry about it then, but for now this looks good to me.

Comment 9

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5b5f49c7b5ad

Comment 10

[Masatoshi Kimura [:emk]]

Comment on attachment 795433 [details] [diff] [review]
Part 1: Introduce a struct containing protoIfaceArray

We'd revisit when other interfaces ever require the similar logic.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5b5f49c7b5ad
https://hg.mozilla.org/mozilla-central/rev/3b5d3af2e221

Comment 12

[Kohei Yoshino]

https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/26/Site_Compatibility