Closed Bug 909340 Opened 6 years ago Closed 6 years ago

Hide XULElement from content

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: emk, Assigned: emk)

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(4 files)

No description provided.
mDefined will be used in following patches.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #795433 - Flags: review?(bzbarsky)
Without this patch, aDefineOnGlobal will be effectively ignored if GetProtoObject is called before GetConstructorObject. And it is unpredictable when GetConstructorObject is called because GlobalResolve calls it lazily.
Attachment #795434 - Flags: review?(bzbarsky)
Attachment #795433 - Attachment description: Part 1: Introduce a struct contaning protoIfaceArray → Part 1: Introduce a struct containing protoIfaceArray
I'm not sure what I think of the additional complexity....  Peter?
Flags: needinfo?(peterv)
This is a bit more ad hoc, but much simpler.
Attachment #796714 - Flags: review?(bzbarsky)
Comment on attachment 796714 [details] [diff] [review]
Alternative patch

r=me.

If we ever need this for other interfaces, we can worry about it then, but for now this looks good to me.
Attachment #796714 - Flags: review?(bzbarsky) → review+
Flags: in-testsuite+
Comment on attachment 795433 [details] [diff] [review]
Part 1: Introduce a struct containing protoIfaceArray

We'd revisit when other interfaces ever require the similar logic.
Attachment #795433 - Flags: review?(bzbarsky)
Attachment #795434 - Flags: review?(bzbarsky)
Attachment #795435 - Flags: review?(bzbarsky)
https://hg.mozilla.org/mozilla-central/rev/5b5f49c7b5ad
https://hg.mozilla.org/mozilla-central/rev/3b5d3af2e221
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Flags: needinfo?(peterv)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.