909400 - Page actions icon disappears on tab switch

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Currently swapping a tab will end up dropping the visible page action icon for an associated tab.

i) Visit Google Maps; see Android icon in URL bar for Google Maps (native application)
ii) Open a new tab to about:home
iii) Swap back to the Google Maps tab

Expected: Page action tappable icon still present 
Actual: Page action tappable icon vanished

--
Nightly (08/26) | LG Nexus 4 (Android 4.3)

Comment 1

[Shilpan Bhagat]

Attachment: Patch: Show relevant pageaction for helper app on tab switch

This fixes the regression.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

I wonder if we should instead make HelperApps listen for "TabSelect"? That way we can decouple the code a bit more. I guess the same is true for Reader.

File a new bug?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

If "TabSelect" does not work for some reason, we could add a new event in the active setter.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/654a1078dbd7

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/654a1078dbd7

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Pinging Wes about comment 2

Comment 7

[Wesley Johnston (:wesj)]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> I wonder if we should instead make HelperApps listen for "TabSelect"? That
> way we can decouple the code a bit more. I guess the same is true for Reader.
> 
> File a new bug?

Sorry for the delay. Filed bug 963751.