Closed Bug 909415 Opened 11 years ago Closed 11 years ago

Bug 904743 "fixed" bindings dependencies to be wrong

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla26

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

*Binding.pp should contain deps for the *Binding file, not for the *Binding.h and *Binding.cpp files.  The bindings rules use this to avoid regenerating bingings unnecessarily.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Comment on attachment 795536 [details] [diff] [review]
Fix binding .pp files to not overbuild due to listing dependencies for the wrong file.

Review of attachment 795536 [details] [diff] [review]:
-----------------------------------------------------------------

Please add a big comment here telling people not to fiddle with this ;-)

r=me
Attachment #795536 - Flags: review?(khuey) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/855d24ed747f
Flags: in-testsuite-
Target Milestone: --- → mozilla26
https://hg.mozilla.org/mozilla-central/rev/855d24ed747f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: