Closed
Bug 909455
Opened 11 years ago
Closed 11 years ago
FHR recordSearch calls missing from new URL entering logic
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(firefox26 affected, fennec26+)
RESOLVED
FIXED
Firefox 26
People
(Reporter: Margaret, Assigned: Margaret)
References
Details
Attachments
(1 file)
3.71 KB,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
While looking into bug 908344, I found that there was some FHR-related stuff in AweseomBar that disappeared after the fig merge: https://hg.mozilla.org/mozilla-central/annotate/a3cc1c802366/mobile/android/base/AwesomeBar.java#l359 I think we need to move this logic into BrowserToolbar now.
Assignee | ||
Comment 1•11 years ago
|
||
We'll want to land the patch in bug 908344 before fixing this.
Depends on: 908344
Comment 2•11 years ago
|
||
See Bug 873496, which I marked as a dependency of Bug 862793 for precisely this eventuality ;) Thanks for keeping your eyes open, margaret!
Updated•11 years ago
|
status-firefox26:
--- → affected
Updated•11 years ago
|
Assignee: nobody → margaret.leibovic
tracking-fennec: ? → 26+
Assignee | ||
Comment 3•11 years ago
|
||
This is just a port of the old AwesomeBar logic.
Attachment #799510 -
Flags: review?(rnewman)
Comment 4•11 years ago
|
||
Comment on attachment 799510 [details] [diff] [review] patch Review of attachment 799510 [details] [diff] [review]: ----------------------------------------------------------------- LGTM. Please verify that you get recorded searches in your healthreport doc before landing!
Attachment #799510 -
Flags: review?(rnewman) → review+
Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/106d7014a45a While testing this, I found another bug that prevents keyword searches from being recorded, but that will be handled in bug 913713.
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/106d7014a45a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•