909482 - error: NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIDOMWindowUtils.getViewId]

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Browser, defect)

Description

[Jim Mathies [:jimm]]

I see thousands of these when scrolling a page via touch.

Looks like this line needs an apz enabled test:

http://mxr.mozilla.org/mozilla-central/source/browser/metro/base/content/bindings/browser.js#705

Comment 1

[Jim Mathies [:jimm]]

Attachment: fix

Looks like we don't have to do any of this scroll processing if apz isn't enabled.

Comment 2

[Jim Mathies [:jimm]]

Attachment: export patch

Comment 3

[Botond Ballo [:botond]]

Comment on attachment 795614 [details] [diff] [review]
fix

Review of attachment 795614 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

::: browser/metro/base/content/bindings/browser.js
@@ +553,5 @@
>    init: function() {
>      addMessageListener("Content:SetCacheViewport", this);
>      addMessageListener("Content:SetWindowSize", this);
>  
> +    if (Services.prefs.getBoolPref(kAsyncPanZoomEnabled)) {

Is kAsyncPanZoomEnabled visible in this file? I see it's defined in browser/metro/base/content/input.js. Sorry if this is a silly question, I'm still just getting the hang of JS.

Comment 4

[Jim Mathies [:jimm]]

Attachment: fix

ah, good catch. It's not since this is a binding.

Comment 5

[Botond Ballo [:botond]]

Comment on attachment 795641 [details] [diff] [review]
fix

Review of attachment 795641 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks!

Comment 6

[Jim Mathies [:jimm]]

Attachment: export patch

thanks for the quick turn around.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/c2daf80c0669

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c2daf80c0669