Closed
Bug 909495
Opened 11 years ago
Closed 11 years ago
Fix hard coded --xre-path for cppunittests in mozharness config
Categories
(Release Engineering :: Applications: MozharnessCore, defect)
Release Engineering
Applications: MozharnessCore
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dminor, Assigned: dminor)
Details
Attachments
(1 file)
3.07 KB,
patch
|
mozilla
:
review+
mozilla
:
checked-in+
|
Details | Diff | Splinter Review |
The --xre-path option is hard coded in the config files for each platform. This is working for Linux and Windows, but fails for Mac [1]. Rather than fixing the hard coded path for Mac, I think it makes more sense to set it dynamically based upon where things are unpacked. [1] https://tbpl.mozilla.org/?tree=Cedar&rev=80c7d8f26341&showall=1
Assignee | ||
Comment 1•11 years ago
|
||
I wasn't sure if it was better to match the script variable name or the existing naming convention in the config files. Let me know if you would prefer something else.
Updated•11 years ago
|
Attachment #796021 -
Flags: review?(aki) → review+
Comment 2•11 years ago
|
||
Comment on attachment 796021 [details] [diff] [review] Patch to fix hardcoded paths in config files. https://hg.mozilla.org/build/mozharness/rev/f1284657517b
Attachment #796021 -
Flags: checked-in+
Comment 3•11 years ago
|
||
In production.
Assignee | ||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Component: General Automation → Mozharness
You need to log in
before you can comment on or make changes to this bug.
Description
•