909653 - Use JSONRPC (if available) to populate the components on the 'My requests' page

Status: RESOLVED WONTFIX

(Bugzilla :: Attachments & Requests, defect)

Description

[Simon Green]

The My Requests page generates an array of arrays in the HTML (of components for products). When you have 60,000 components (like brc does), this is inefficient, and causes the browser to hang.

This patch will make this page use JSONRPC if it is available to populate the component list.

Note: This means that if the SITE has JSONRPC available, then the admin USER must have Javascript enabled. It was decided at last months Bugzilla meeting that it was okay to assume that Bugzilla pages require Javascript to fully function.

The changes has no effect if the site does not have JSONRPC available.

Comment 1

[Simon Green]

Attachment: v1 patch

This uses the same js/component.js as the patch in bug 909203 uses. Obviously it only needs to be committed once.

Comment 2

[Frédéric Buclin]

/me didn't know RH had so many bugs... 10^12 is a lot of bugs. ;)

Comment 3

[Simon Green]

(In reply to Frédéric Buclin from comment #2)
> /me didn't know RH had so many bugs... 10^12 is a lot of bugs. ;)

It is a lot of bugs. Thankfully we don't have that many ... yet :)

Comment 4

[Gervase Markham [:gerv]]

Hi Simon,

This will make the page slower in the common case, because the page will need to load and then the RPC call will need to complete. Instead of making the new mode of working conditional on the presence of JSON-RPC, can you make it conditional on both that and a number of components > a certain threshold (say 300)?

That way, short lists will still be quick, and long lists will work.

Gerv

Comment 5

[Gervase Markham [:gerv]]

Oh, and same question for bug 909203.

Gerv

Comment 6

[Simon Green]

(In reply to Gervase Markham [:gerv] from comment #4)
> Hi Simon,
> 
> This will make the page slower in the common case, because the page will
> need to load and then the RPC call will need to complete.

I disagree. In the common case (and with bug 909203), I imagine that most users will not hit the AJAX code at all. When I look at the My Requests page, I never change the product or component. With the Flag Types Admin pages (which is the other) bugs, I sometimes use the products on the Edit Page, but not on the list page.

> Instead of making
> the new mode of working conditional on the presence of JSON-RPC, can you
> make it conditional on both that and a number of components > a certain
> threshold (say 300)?
> 
> That way, short lists will still be quick, and long lists will work.

I disagree. Take brc for example, where we have 257 products, and the average length of component names is 12 characters. If all those products had 299 components[1], then that is nearly 1 MB of extra data[2] that needs to be generated on the server, and parsed by the client, which leads to the performance issues that we have.

This also makes the JS more complicated than it needs to be.

[1] yes, this is not true but is used as an extreme example
[2] 257*299*12 = 922116 bytes + extra for the quotes, commas and spaces.

Comment 7

[Simon Green]

I've dropped the original patch as the JS used in bug 227611 can be used for this code too. Once that bug hits trunk, I'll do a new patch for this bug.