909684 - B2G RIL: Add 'enabled' and 'password' check for setCallBarringOption

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Szu-Yu Chen [:aknow] (inactive)]

This part is missing in  original design. Fix it.

Comment 1

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Add enabled and password checking

Comment 2

[Hsin-Yi Tsai (she/her)[:hsinyi]]

Comment on attachment 795913 [details] [diff] [review]
Add enabled and password checking

Review of attachment 795913 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/RILContentHelper.js
@@ +2037,5 @@
>    /**
>     * Helper for guarding us against invalid option for call barring.
>     */
> +  _isValidCallBarringOption:
> +      function _isValidCallBarringOption(option, useForSet) {

useForSet seems weird/incorrect in Grammar. 

usedForSetting? or setting? maybe...

@@ +2044,5 @@
> +        !this._isValidCallBarringProgram(option.program)) {
> +      return false;
> +    }
> +
> +    // For set callbarring, enabled and password are required.

For setting call barring, ...

Comment 3

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: [Final] Add enabled and password checking. r=hsinyi

Use 'usedForSetting' in my final version

Comment 4

[Szu-Yu Chen [:aknow] (inactive)]

https://tbpl.mozilla.org/?tree=Try&rev=63d9d3816201

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/8e7bb633375b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8e7bb633375b