Closed Bug 909684 Opened 8 years ago Closed 8 years ago

B2G RIL: Add 'enabled' and 'password' check for setCallBarringOption

Categories

(Core :: DOM: Device Interfaces, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: aknow, Assigned: aknow)

Details

Attachments

(1 file, 1 obsolete file)

This part is missing in  original design. Fix it.
Attachment #795913 - Flags: review?(htsai)
Comment on attachment 795913 [details] [diff] [review]
Add enabled and password checking

Review of attachment 795913 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/RILContentHelper.js
@@ +2037,5 @@
>    /**
>     * Helper for guarding us against invalid option for call barring.
>     */
> +  _isValidCallBarringOption:
> +      function _isValidCallBarringOption(option, useForSet) {

useForSet seems weird/incorrect in Grammar. 

usedForSetting? or setting? maybe...

@@ +2044,5 @@
> +        !this._isValidCallBarringProgram(option.program)) {
> +      return false;
> +    }
> +
> +    // For set callbarring, enabled and password are required.

For setting call barring, ...
Attachment #795913 - Flags: review?(htsai) → review+
Use 'usedForSetting' in my final version
Attachment #795913 - Attachment is obsolete: true
Attachment #798451 - Flags: review?
Attachment #798451 - Flags: review?
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8e7bb633375b
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.