909706 - Keyboard manager must wait for applicationready to enumerate all keyboard apps

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

When Keyboard Manager runs init() keyboard helper(shared/js/keyboard_helper.js) will use |navigator.mozApps.mgmt.getAll()| for enumerating all keyboard apps.

We saw some code like system/js/bootstrap.js will wait for |Applications.ready| or listen |applicationready| event to prevent gecko not ready for |mozApps.mgmt| . 

Seems Keyboard manager need to wait for |applicationready| to run init().

Comment 1

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: WIP patch

Hi Alive and Rudy,
   This is my WIP patch.
   Is it right for listening |applicationready| before we do |mozApps.mgmt.getAll()|?
   
   In shared/js/keyboard_helper.js line145
   https://github.com/mpizza/gaia/commit/dd2079019149f5ac1c8d3ed9b47e28b1e64f10e7#L7R145

   please give me some feedback thanks.

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 796108 [details]
WIP patch

Looks good to me.
Thanks for taking care of this.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 796108 [details]
WIP patch

How about KeyboardHelper? It shouldn't do init() right away it's included. Or we shall lazy load it.

Comment 4

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

good point~
Thanks Rudy and Alive

I will fix it.

Comment 5

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: pull request: https://github.com/mozilla-b2g/gaia/pull/11886

Hi Alive,
   I've update my patch and addressed your comment, please help review this patch.
   Thanks.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 798503 [details]
pull request: https://github.com/mozilla-b2g/gaia/pull/11886

r=me iff KeyboardManager doesn't depend on KeyboardHelper load status.

Comment 7

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Thanks alive,
landed in b2g master.

https://github.com/mozilla-b2g/gaia/commit/9839638881e22c53ee54d7a27a7d5c5e2b2c1081
https://github.com/mozilla-b2g/gaia/commit/65abc8c4cd0138abfa58f69acd33c32e315d8d2c