909758 - add mutex click to console filter buttons

Status: RESOLVED DUPLICATE of bug 879293

(DevTools :: Console, defect, P2)

Description

[Anthony Ricaud (:rik)]

Right now, it's cumbersome to switch between types of logging and level of logging. To focus on one kind of logging, you need to uncheck all the other ones. If you want to change the logging level, you need to do it in all types.

I'd suggest moving to two radio controls for this. Like this beautiful ASCII art!

/-------------------------------------\ /-------------------------------\
| All | CSS | JS | Security | Logging | | All | Errors | Warnings | Log |
\-------------------------------------/ \-------------------------------/

Comment 1

[Paul Rouget [:paul]]

I want that too :0

Comment 2

[Rob Campbell [:rc] (:robcee)]

another proposed solution was to make the current filter buttons mutually exclusive when clicked with an "Alt" modifier applied.

Comment 3

[Paul Rouget [:paul]]

What if I want everything but CSS logs?

Comment 4

[Anthony Ricaud (:rik)]

Click with a modifier, like a <select multiple> ?

Comment 5

[Rob Campbell [:rc] (:robcee)]

(In reply to Paul Rouget [:paul] from comment #3)
> What if I want everything but CSS logs?

turn off CSS logs?

Comment 6

[Paul Rouget [:paul]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #5)
> (In reply to Paul Rouget [:paul] from comment #3)
> > What if I want everything but CSS logs?
> 
> turn off CSS logs?

How do you do that?

The state of "All | Errors | Warnings | Log " changes when you click on one a category?

Comment 7

[Rob Campbell [:rc] (:robcee)]

Attachment: mutex WIP

needs a test

Comment 8

[Paul Rouget [:paul]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #7)
> Created attachment 822407 [details] [diff] [review]
> mutex WIP
> 
> needs a test

Hmm, you've implemented comment 2. Don't we want comment 0? I think I want comment 0.

Comment 9

[Rob Campbell [:rc] (:robcee)]

updating the subject to reflect what we're doing.

Comment 10

[Rob Campbell [:rc] (:robcee)]

paul, what I don't like about the two sets of radio buttons is there are some categories where we want defaults to include everything, and others where we just want errors. This would make that impossible.

At least with an alt-click, you can flip through each category which I think it's the least amount of change to match the cycling behavior Rik describes.

Comment 11

[Mihai Sucan [:msucan]]

Comment on attachment 822407 [details] [diff] [review]
mutex WIP

Review of attachment 822407 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thank you! f+

::: browser/devtools/webconsole/webconsole.js
@@ +727,4 @@
>        return;
>      }
>  
> +    // for convenience...

This comment should be more useful or removed.

Comment 12

[Mihai Sucan [:msucan]]

A contributor is working on this bug.