909782 - TabLists inheriting from BrowserTabList need to be updated to change "iterator" to "getList"

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P1)

Description

[Brandon Benvie [:benvie]]

Recently, in bug 899052 BrowserTabList.prototype was updated to change its "iterator" method to a "getList" method which returns a promise for the items. MetroTabList and MobileTabList both override this with their own, but they were not updated in the original bug. This causes remote debugging to not work on either of them.

Comment 1

[Brandon Benvie [:benvie]]

Attachment: WIP1

This patch refactors `BrowserTabList.prototype.getList` to defer to two new methods, `_getBrowser` and `_getChildren`. These are the only two differences between it and the subclsses of it. The subclasses have had their `iterator` method removed and had these two new methods implemented.

Comment 2

[Brandon Benvie [:benvie]]

Attachment: WIP2

Change "selectedTab" to "selectedBrowser" which is more accurate.

Comment 3

[Brandon Benvie [:benvie]]

https://tbpl.mozilla.org/?tree=Try&rev=729013c85e0f

Comment 4

[Brandon Benvie [:benvie]]

Attachment: WIP3

Rename "_getBrowser" to "_getSelectedBrowser".

Comment 5

[Matt Brubeck (:mbrubeck)]

Comment on attachment 796077 [details] [diff] [review]
WIP3

Review of attachment 796077 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!  r=mbrubeck for the Metro part.  However, some drive-by comments:

B2G also extends this object and will need to be updated:
http://mxr.mozilla.org/mozilla-central/source/b2g/chrome/content/dbg-browser-actors.js

::: mobile/android/chrome/content/dbg-browser-actors.js
@@ +60,3 @@
>  
> +MobileTabList.prototype._getChildren = function(aWindow) {
> +  return aWindow.BrowserApp.tabs;

This should be:

  return aWindow.BrowserApp.tabs.map(tab => tab.browser);

Comment 6

[:Margaret Leibovic]

Comment on attachment 796077 [details] [diff] [review]
WIP3

Review of attachment 796077 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me with mbrubeck's comment addressed.

Comment 7

[Brandon Benvie [:benvie]]

Attachment: WIP4

Addresses mbrubeck's feedback.

* Fix MobileTabList._getChildren
* Change ContentTabList.prototype.iterator to getList that returns a promise resolving to an array containing the single actor.

Comment 8

[Brandon Benvie [:benvie]]

https://hg.mozilla.org/integration/fx-team/rev/6882de8ed28a

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6882de8ed28a