909786 - Use incremental number as the hash key of |controlCallbacks| in NetworkManager::controlMessage()

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Henry Chang [:hchang]]

In NetworkManager.js, when invoking controlMessage(params, callback), the name of callback function would be used as the hash key of |controlCallbacks|. It's unsafe since it's difficult to guarantee all callers using distinct function names.

There is a simple solution already used in WifiManager.js, which is using an incremental |id| as the hash key and delete after callback.

Comment 1

[Henry Chang [:hchang]]

Attachment: Bug909786.patch

Comment 2

[Henry Chang [:hchang]]

Oh oh I found something wrong in the patch. I'll attach another patch for review later on.

Comment 3

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 796071 [details] [diff] [review]
Bug909786.patch

Review of attachment 796071 [details] [diff] [review]:
-----------------------------------------------------------------

Remove from review queue per comment 2.

Comment 4

[Henry Chang [:hchang]]

Attachment: Bug909786.patch

Comment 5

[Henry Chang [:hchang]]

Comment on attachment 797633 [details] [diff] [review]
Bug909786.patch

Verified locally and on Try server
https://tbpl.mozilla.org/?tree=Try&rev=dda8c080b9d3

Comment 6

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 797633 [details] [diff] [review]
Bug909786.patch

Review of attachment 797633 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thank you.

Comment 7

[Henry Chang [:hchang]]

Attachment: Bug909786.patch (has been r+. added r=vchang)

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/687e3a6868bf

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/687e3a6868bf