trackingflags do not support "Can be set on bug creation"

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: glob, Assigned: glob)

Tracking

Production
x86
macOS
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

currently trackingflags are always visible on enter_bug, however not all cf_tracking_flags have this option enabled (notability the thunderbird flags).

we need to:
  - add the bit field to the schema
  - update the flag class
  - add the ui to the admin pages

the migration script over in bug 880829 will need to be updated too.
Attachment #796508 - Flags: review?(dkl)
Comment on attachment 796508 [details] [diff] [review]
909843_1.patch

Review of attachment 796508 [details] [diff] [review]:
-----------------------------------------------------------------

nice r=dkl

::: extensions/TrackingFlags/web/js/admin.js
@@ +16,5 @@
> +        filter_flag_list(Dom.get('filter').checked);
> +    }
> +    else {
> +        if (!JSON)
> +        JSON = YAHOO.lang.JSON;

nit: indent

@@ +25,5 @@
> +
> +        Event.addListener('product', 'change', function() {
> +        if (Dom.get('product').value == '')
> +            Dom.get('component').options.length = 0;
> +        });

nit: need moar indention
Attachment #796508 - Flags: review?(dkl) → review+
(In reply to David Lawrence [:dkl] from comment #2)
> nit: need moar indention

that file had a mix of 2 and 4 space indentation; i fixed the whole file to use 4.

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified extensions/TrackingFlags/Extension.pm
modified extensions/TrackingFlags/lib/Admin.pm
modified extensions/TrackingFlags/lib/Flag.pm
modified extensions/TrackingFlags/template/en/default/pages/tracking_flags_admin_edit.html.tmpl
modified extensions/TrackingFlags/template/en/default/pages/tracking_flags_admin_list.html.tmpl
modified extensions/TrackingFlags/web/js/admin.js
Committed revision 8978.

oops, there's a schema change in there, backing out code which touches enter_bug:

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified extensions/TrackingFlags/Extension.pm
modified extensions/TrackingFlags/lib/Admin.pm
modified extensions/TrackingFlags/lib/Flag.pm
modified extensions/TrackingFlags/template/en/default/pages/tracking_flags_admin_edit.html.tmpl
Committed revision 8979.


leaving open pending mid-push commit.
Status: NEW → ASSIGNED
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified extensions/TrackingFlags/Extension.pm
modified extensions/TrackingFlags/lib/Admin.pm
modified extensions/TrackingFlags/lib/Flag.pm
modified extensions/TrackingFlags/template/en/default/pages/tracking_flags_admin_edit.html.tmpl
Committed revision 8993.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.