909916 - Lightning windows l10n repacks fail on beta

Status: RESOLVED FIXED

(Calendar :: Build Config, defect, P1)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

The build automation for l10n repacks fails on windows because a certain variable is not defined. The only difference to the working 2.5 betas is the introduction of pymake.

rail, I'd appreciate if you could test this on your staging.

Comment 1

[Rail Aliiev [:rail]]

Comment on attachment 796238 [details] [diff] [review]
Fix - v1

So far I could test it only on linux. Some locales work fine, some of them fail with the following error. lightning-2.6b1..linux-i686.xpi looks strange.
Alos 

command: START
command: make installers-zh-CN
command: cwd: comm-beta/obj-l10n/mail/locales
command: env: {'MOZ_MAKE_COMPLETE_MAR': '1', 'AB_CD': 'zh-CN', 'MOZ_SIGN_CMD': 'python /builds/slave/tb-rel-c-beta-lx_rpk_6-0000000/scripts/release/signing/signtool.py --cachedir /builds/slave/tb-rel-c-beta-lx_rpk_6-0000000/signing_cache -t /builds/slave/tb-rel-c-beta-lx_rpk_6-0000000/token -n /builds/slave/tb-rel-c-beta-lx_rpk_6-0000000/nonce -c /builds/slave/tb-rel-c-beta-lx_rpk_6-0000000/scripts/release/signing/host.cert -H signing4.srv.releng.scl3.mozilla.com:9120 -H signing5.srv.releng.scl3.mozilla.com:9120 -H signing6.srv.releng.scl3.mozilla.com:9120', 'UPLOAD_SSH_KEY': '~/.ssh/tbirdbld_dsa', 'LOCALE_MERGEDIR': '/builds/slave/tb-rel-c-beta-lx_rpk_6-0000000/comm-beta/obj-l10n/mail/locales/merged', 'COMM_REV': 'THUNDERBIRD_24_0b2_RELEASE', 'MOZ_OBJDIR': 'obj-l10n', 'MAR': '/builds/slave/tb-rel-c-beta-lx_rpk_6-0000000/comm-beta/obj-l10n/mozilla/dist/host/bin/mar', 'UPLOAD_TO_TEMP': '1', 'LD_LIBRARY_PATH': '/tools/gcc-4.3.3/installed/lib', 'ZIP_IN': '/builds/slave/tb-rel-c-beta-lx_rpk_6-0000000/thunderbird.tar.bz2', 'UPLOAD_USER': 'tbirdbld', 'MBSDIFF': '/builds/slave/tb-rel-c-beta-lx_rpk_6-0000000/comm-beta/obj-l10n/mozilla/dist/host/bin/mbsdiff', 'UPLOAD_EXTRA_FILES': 'update/linux-i686/vi/thunderbird-23.0b1-24.0b2.partial.mar update/linux-i686/vi/thunderbird-23.0b1-24.0b2.partial.mar.asc', 'UPLOAD_HOST': 'dev-stage01.srv.releng.scl3.mozilla.com', 'POST_UPLOAD_CMD': 'post_upload.py -p thunderbird -n 1 -v 24.0b2 --release-to-candidates-dir --signed', 'MOZILLA_REV': 'THUNDERBIRD_24_0b2_RELEASE', 'MOZ_PKG_PRETTYNAMES': '1', 'MOZ_PKG_VERSION': '24.0b2'}
command: output:
make -C ../../calendar/lightning langpack-zh-CN
make[1]: Entering directory `/builds/slave/tb-rel-c-beta-lx_rpk_6-0000000/comm-beta/obj-l10n/calendar/lightning'
(cd ../../mozilla/dist/xpi-stage && wget -nv -N http://dev-stage01.srv.releng.scl3.mozilla.com/pub/mozilla.org/calendar/lightning/nightly/2.6b1-candidates/build1/linux-i686/lightning-2.6b1..linux-i686.xpi)
http://dev-stage01.srv.releng.scl3.mozilla.com/pub/mozilla.org/calendar/lightning/nightly/2.6b1-candidates/build1/linux-i686/lightning-2.6b1..linux-i686.xpi:
2013-08-28 03:57:04 ERROR 404: Not Found.
make[1]: *** [wget-en-US] Error 8
make[1]: Leaving directory `/builds/slave/tb-rel-c-beta-lx_rpk_6-0000000/comm-beta/obj-l10n/calendar/lightning'
make: *** [calendar-langpack-zh-CN] Error 2
command: ERROR
Traceback (most recent call last):
  File "/builds/slave/tb-rel-c-beta-lx_rpk_6-0000000/scripts/scripts/l10n/../../lib/python/util/commands.py", line 47, in run_cmd
    return subprocess.check_call(cmd, **kwargs)
  File "/usr/lib64/python2.6/subprocess.py", line 502, in check_call
    raise CalledProcessError(retcode, cmd)
CalledProcessError: Command '['make', 'installers-zh-CN']' returned non-zero exit status 2
command: END (0.50s elapsed)

Comment 2

[Rail Aliiev [:rail]]

(In reply to Rail Aliiev [:rail] from comment #1)
> Alos 

Disregard this.

Comment 3

[Rail Aliiev [:rail]]

Windows:

command: START
command: make installers-de
command: cwd: comm-beta\obj-l10n\mail\locales
command: env: {'MOZ_MAKE_COMPLETE_MAR': '1', 'AB_CD': 'de', 'MOZ_SIGN_CMD': 'python /e/builds/moz2_slave/tb-rel-c-beta-w32_rpk_2-000000/scripts/release/signing/signtool.py --cachedir /e/builds/moz2_slave/tb-rel-c-beta-w32_rpk_2-000000/signing_cache -t /e/builds/moz2_slave/tb-rel-c-beta-w32_rpk_2-000000/token -n /e/builds/moz2_slave/tb-rel-c-beta-w32_rpk_2-000000/nonce -c /e/builds/moz2_slave/tb-rel-c-beta-w32_rpk_2-000000/scripts/release/signing/host.cert -H signing4.srv.releng.scl3.mozilla.com:9120 -H signing5.srv.releng.scl3.mozilla.com:9120 -H signing6.srv.releng.scl3.mozilla.com:9120', 'WIN32_INSTALLER_IN': '/e/builds/moz2_slave/tb-rel-c-beta-w32_rpk_2-000000/thunderbird.exe', 'UPLOAD_SSH_KEY': '~\\.ssh\\tbirdbld_dsa', 'LOCALE_MERGEDIR': '/e/builds/moz2_slave/tb-rel-c-beta-w32_rpk_2-000000/comm-beta/obj-l10n/mail/locales/merged', 'COMM_REV': 'THUNDERBIRD_24_0b2_RELEASE', 'MOZ_OBJDIR': 'obj-l10n', 'MAR': '/e/builds/moz2_slave/tb-rel-c-beta-w32_rpk_2-000000/comm-beta/obj-l10n/mozilla/dist/host/bin/mar.exe', 'UPLOAD_TO_TEMP': '1', 'LD_LIBRARY_PATH': '', 'ZIP_IN': '/e/builds/moz2_slave/tb-rel-c-beta-w32_rpk_2-000000/thunderbird.zip', 'UPLOAD_USER': 'tbirdbld', 'MBSDIFF': '/e/builds/moz2_slave/tb-rel-c-beta-w32_rpk_2-000000/comm-beta/obj-l10n/mozilla/dist/host/bin/mbsdiff.exe', 'UPLOAD_HOST': 'dev-stage01.srv.releng.scl3.mozilla.com', 'POST_UPLOAD_CMD': 'post_upload.py -p thunderbird -n 1 -v 24.0b2 --release-to-candidates-dir --signed', 'MOZILLA_REV': 'THUNDERBIRD_24_0b2_RELEASE', 'MOZ_PKG_PRETTYNAMES': '1', 'MOZ_PKG_VERSION': '24.0b2'}
command: output:
make -C ../../calendar/lightning langpack-de
make[1]: Entering directory `/e/builds/moz2_slave/tb-rel-c-beta-w32_rpk_2-000000/comm-beta/obj-l10n/calendar/lightning'
mkdir -p ../../mozilla/dist/xpi-stage
(cd ../../mozilla/dist/xpi-stage && wget -nv -N http://dev-stage01.srv.releng.scl3.mozilla.com/pub/mozilla.org/calendar/lightning/nightly/2.6b1-candidates/build1/win32/lightning-2.6b1..win32.xpi)
make[1]: Leaving directory `/e/builds/moz2_slave/tb-rel-c-beta-w32_rpk_2-000000/comm-beta/obj-l10n/calendar/lightning'
command: ERROR
Traceback (most recent call last):
  File "e:/builds/moz2_slave/tb-rel-c-beta-w32_rpk_2-000000/scripts/scripts/l10n\../../lib/python\util\commands.py", line 47, in run_cmd
    return subprocess.check_call(cmd, **kwargs)
  File "c:\mozilla-build\python27\lib\subprocess.py", line 511, in check_call
    raise CalledProcessError(retcode, cmd)
CalledProcessError: Command '['make', 'installers-de']' returned non-zero exit status 2
command: END (0.57s elapsed)

retry: Calling <function downloadUpdateIgnore404 at 0x02910B30> with args: ('dev-stage01.srv.releng.scl3.mozilla.com', 'thunderbird', '23.0b1', 1, 'win32', 'el'), kwargs: {}, attempt #1
Downloading http://dev-stage01.srv.releng.scl3.mozilla.com/pub/mozilla.org/thunderbird/candidates/23.0b1-candidates/build1/update/win32/el/thunderbird-23.0b1.complete.mar to thunderbird-23.0b1.el.complete.mar
http://dev-stage01.srv.releng.scl3.mozilla.com/pub/mozilla.org/calendar/lightning/nightly/2.6b1-candidates/build1/win32/lightning-2.6b1..win32.xpi:
07:56:38 ERROR 404: Not Found.
make[1]: *** [wget-en-US] Error 1
make: *** [calendar-langpack-de] Error 2

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v2

This one should do better. Although I couldn't test it to completion on the builder, this patch works locally using the same call and environment that the builders use.

I've tried to test this in staging, but there is an error during preprocessing that I think doesn't have to do with this patch. The actual problem that the files couldn't be downloaded was proven to be solved.

c:\builds\moz2_slave\tb-rel-c-beta-w32_rpk_1-000000\comm-beta\obj-l10n\mozilla\_virtualenv\Scripts\python.exe: No module named mozbuild.action.preprocessor


iirc then you guys had other issues with win32 l10n repacks? Maybe its a similar issue?

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8384518 [details] [diff] [review]
Fix - v2

Review of attachment 8384518 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable to me, our l10n issue is bug 909952

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset ef008ee4723a