909943 - Phase 2: First Run Testing: Build query parameter varying /firstrun page

Status: VERIFIED FIXED

(www.mozilla.org :: Pages & Content, defect, P3)

Description

[Chris More [:cmore]]

We need to build a new version of the /firstrun page that will be for en-US only.

The page's content will need to vary depending on query parameters as opposed to URLs/directories as we did before. i.e. no /firstrun/a/ but instead /firstrun/?f=xx.

Visiting the /firstrun page with no ?f=[0-9]+ should result in the current firstrun page with the video. When f=[0-9]+ is in query string, it should display the winning page that Jon created in bug 865433. All of this code should already be done and we are just changing the display logic so that:

a) https://www.mozilla.org/en-US/firefox/24.0/firstrun/ should display the current brand video.

b) https://www.mozilla.org/en-US/firefox/24.0/firstrun/?f=25 should display what is currently being displayed at https://www.mozilla.org/en-US/firefox/22.0/firstrun/a/

This is explained in more detail here:

https://bugzilla.mozilla.org/show_bug.cgi?id=901028#c1

Comment 1

[Chris More [:cmore]]

When this page new page start to be developed? I need an estimate on completion or at least on -dev.

Comment 2

[Jonathan Petto [:jpetto]]

I'm starting development on this bug today. Unless something unforeseen happens, it should be ready for testing by Wednesday, 9/4.

Just to confirm:

- The firstrun test URLs (/firefox/22.0/firstrun/a/ & /firefox/22.0/firstrun/b/) should be removed.

- The /b/ variation should be removed.

- The 'f' querystring param must be 25 to view the alternate/new/a variation firstrun content. Any other values (24, 26, 27, latest, etc) should display the standard/video only firstrun content.

Is that all correct?

Comment 3

[Jonathan Petto [:jpetto]]

Another confirmation: this only affects en-US. Other locales will only see the standard/video only firstrun content, regardless of querystring, correct?

Comment 4

[Chris More [:cmore]]

(In reply to Jon Petto [:jpetto] from comment #3)
> Another confirmation: this only affects en-US. Other locales will only see
> the standard/video only firstrun content, regardless of querystring, correct?

Correct, en-US only.

if [query_string.f == 25 && locale == en-US]
  then {display firstrun product content}
  else{ display video content }

the URL will always stay same except for the query parameter. Also, since the firstrun content is the same regardless of what version of Firefox you are running, this page's content should follow the logic above regardless of what version of Firefox is in the URL. 

www.mozilla.org/firefox/22.0/firstrun/?f=25

www.mozilla.org/firefox/26.0/firstrun/?f=25

Both should display the product content. 

Also, make it value f query parameter used in the logic a variable so that if we need to run this again, we can increment the funnelcake version and it will all still work.

Comment 5

[Chris More [:cmore]]

(In reply to Jon Petto [:jpetto] from comment #2)
> I'm starting development on this bug today. Unless something unforeseen
> happens, it should be ready for testing by Wednesday, 9/4.
> 
> Just to confirm:
> 
> - The firstrun test URLs (/firefox/22.0/firstrun/a/ &
> /firefox/22.0/firstrun/b/) should be removed.

yes, remove

> 
> - The /b/ variation should be removed.

Yes, /a/ won, and it should be what is displayed for ?f=25, but it shouldn't reside at a /a/ URL.

> - The 'f' querystring param must be 25 to view the alternate/new/a variation
> firstrun content. Any other values (24, 26, 27, latest, etc) should display
> the standard/video only firstrun content.

Correct, including no f at all.

> 
> Is that all correct?

Comment 6

[Chris More [:cmore]]

Jon: What is the status of this page? Is there a PR yet?

Comment 7

[Jonathan Petto [:jpetto]]

Chris: Today is my first day back teaching. I'll have a PR ready tomorrow.

> Also, make it value f query parameter used in the logic a variable so that
> if we need to run this again, we can increment the funnelcake version and it
> will all still work.

Is the funnelcake version number available somewhere in bedrock to reference? I'll check with pmac tomorrow morning to see if there's an elegant way to keep this new view in sync with the funnelcake version number.

Comment 8

[Jonathan Petto [:jpetto]]

PR submitted: https://github.com/mozilla/bedrock/pull/1207

Changing the accepted value of the f parameter will require a PR/code push. Change is simple though - just need to update constant in /bedrock/firefox/views.py.

Comment 9

[Jennifer Bertsch [:jbertsch]]

Mike and Pmac - Could we please get this one live this week so that we can get the funnel cake test up and running asap?  Thanks!

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/b257564c4bf1ba56bf6128216aa29b13351f4b78
Add querystring test URL for fx firstrun. Bugs 901028, 909943.

- Remove old A/B firstrun test URLs

- Remove B firstrun template

- Remove GA experiment code from /firefox/firstrun/

- Add GA experiment code to /firefox/new/

https://github.com/mozilla/bedrock/commit/754cdd61decd07e83781ad052505a93e64fa3a27
Merge pull request #1207 from jpetto/bug-909943-firstrun-test-querystring

Add querystring test URL for fx firstrun. Bug 909943.

Comment 11

[Chris More [:cmore]]

The pages are up on dev to test:

Original:

https://www-dev.allizom.org/en-US/firefox/23.0/firstrun/

Variation 1: (same)

https://www-dev.allizom.org/en-US/firefox/23.0/firstrun/?f=24

Variation 2: (product content) 

https://www-dev.allizom.org/en-US/firefox/23.0/firstrun/?f=25

Gareth: Can you verify the following?

1) The URLs above are all firing off GA events for the video play and the product features.

2) The correct GA experiment tag is on: https://www-dev.allizom.org/en-US/firefox/new/

Thanks!

Comment 12

[Gareth Cull [:garethc]]

Will do. I'll check it out and will get back to you with an update.

Comment 13

[Gareth Cull [:garethc]]

Hey Chris,

I've verified All of the GA events are working correctly for Original, Variation 1 and 2 firstrun pages. I've captured the events in Real-Time within the images below as confirmation that we can see the data flowing into GA:

Original: http://cl.ly/image/3t0T461O0k3O
Variation 1 (f=24): http://cl.ly/image/3L2w142y0a1M  
Variation 2 (f=25): http://cl.ly/image/2n0I032U352M

Also, the experiment ID on /new matches the ID in our GA experiment called: 
FirstRun Funnel Cake ADI Experiment.

Comment 14

[Chris More [:cmore]]

I've tested this and it all looks good along with Gareth's confirmation. We can go to production. Nothing will be used now until Firefox 24 comes out.

Comment 15

[raymond [:retornam] (inactive)]

fixed on stage

https://www.allizom.org/en-US/firefox/23.0/firstrun/?f=24

Variation 2: (product content) 

https://www.allizom.org/en-US/firefox/23.0/firstrun/?f=25

Comment 16

[Chris More [:cmore]]

On prod:

https://www.mozilla.org/en-US/firefox/23.0/firstrun/?f=25

https://www.mozilla.org/en-US/firefox/23.0/firstrun/?f=24

Comment 17

[raymond [:retornam] (inactive)]

verified fixed