910082 - Netmonitor Sidepane should be animated

Status: RESOLVED WONTFIX

(DevTools :: Netmonitor, defect)

Description

[André Miranda]

Attachment: netmonitor-sidepane-animation.patch

Just like the sidepane on Debugging, the sidepane present on Netmonitor should open/close in a animated way.

Comment 1

[Victor Porof [:vporof][:vp]]

Comment on attachment 796435 [details] [diff] [review]
netmonitor-sidepane-animation.patch

Review of attachment 796435 [details] [diff] [review]:
-----------------------------------------------------------------

The patch is top notch, however I don't think we should really do this, or have it enabled by default. Unlike the debugger, the netmonitor's sidepane can be a lot wider and the animation will be slower and choppier, because the contents are more complex (it doesn't contain just a simple variables view).

I would be willing to r+ a patch that adds a pref for adding the animation, but disabled by default. And in that case, it will be terribly hard to discover this customization option, in which case I'm not sure it's worth the effort.

Rob, what do you think?

Comment 2

[André Miranda]

I don't think an option just to enable this animation is a good idea.
If this animation is considered unnecessary or might be slowish in some scenarios, no problem, it was just a suggestion :)

Comment 3

[Victor Porof [:vporof][:vp]]

(In reply to André Miranda from comment #2)

Ok then! Thanks for looking into this :)