910088 - Use webIDL dictionaries for DOMWindowResize event details

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kan-Ru Chen [:kanru] (UTC+9)]

As in bug 906901

Comment 1

[Boris Zbarsky [:bzbarsky]]

This needs to happen.  The situation as done in bug 891763 is not OK, and we shouldn't be shipping it.

Comment 2

[Boris Zbarsky [:bzbarsky]]

More precisely, I don't think the patch in bug 891763 should have gotten r+.

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Do we want to backout the landing in bug 891763? It only landed to trunk 5 hours ago.

Comment 4

[Boris Zbarsky [:bzbarsky]]

No, I don't think things are that dire.

Comment 5

[Justin Lebar (not reading bugmail)]

(In reply to Boris Zbarsky [:bz] from comment #2)
> More precisely, I don't think the patch in bug 891763 should have gotten r+.

I'm really sorry about that.

While we're here we should probably also fix nsIAsyncScrollEventDetail.

Comment 6

[Boris Zbarsky [:bzbarsky]]

What's the problem with nsIAsyncScrollEventDetail?

Comment 7

[Boris Zbarsky [:bzbarsky]]

I mean other than it not being used afaict.

Comment 8

[Justin Lebar (not reading bugmail)]

(In reply to Boris Zbarsky [:bz] from comment #6)
> What's the problem with nsIAsyncScrollEventDetail?

Oh, I see that it's been converted and moved into BrowserElementDictionaries.webidl.

> I mean other than it not being used afaict.

So I guess nothing, aside from this.  :)

Comment 9

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: Patch

Comment 10

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: Patch

Use new API

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 797043 [details] [diff] [review]
Patch

>+  AutoSafeJSContext cx;

I think you need to enter the compartment of the window's JSObject on this cx.

>+  detail.ToObject(cx, JS::NullPtr(), &detailValue);

And if this returns false, return false.

r=me with those fixed.  Thank you!

Comment 12

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: Patch to commit

Comment 13

[Kan-Ru Chen [:kanru] (UTC+9)]

https://hg.mozilla.org/integration/b2g-inbound/rev/f3d8e568ec11

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f3d8e568ec11

Comment 15

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Boris Zbarsky [:bz] from comment #11)
> >+  detail.ToObject(cx, JS::NullPtr(), &detailValue);
> 
> And if this returns false, return false.

Why did you not address this comment?

Comment 16

[Kan-Ru Chen [:kanru] (UTC+9)]

(In reply to :Ms2ger from comment #15)
> (In reply to Boris Zbarsky [:bz] from comment #11)
> > >+  detail.ToObject(cx, JS::NullPtr(), &detailValue);
> > 
> > And if this returns false, return false.
> 
> Why did you not address this comment?

Oops. I forgot it. Sorry.

Comment 17

[Kan-Ru Chen [:kanru] (UTC+9)]

https://hg.mozilla.org/integration/b2g-inbound/rev/08227e64ea54

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/08227e64ea54