910256 - "System JS : ERROR resource://app/modules/webappsUI.jsm:45 TypeError: this.downloads[data.manifest] is undefined" in green mochitest-2 runs

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=27114921&tree=Mozilla-Central

Ubuntu VM 12.04 mozilla-central opt test mochitest-2 on 2013-08-28 06:01:54 PDT for push 44e615a66f3f
slave: tst-linux32-ec2-019

06:06:00     INFO -  655 INFO TEST-PASS | /tests/dom/apps/tests/test_app_update.html | Got download progress
06:06:00     INFO -  Server Etag: apptype-cached-getappcache-true-3
06:06:00     INFO -  No Client Etag
06:06:00     INFO -  System JS : ERROR resource://app/modules/webappsUI.jsm:45
06:06:00     INFO -                       TypeError: this.downloads[data.manifest] is undefined
06:06:00     INFO -  656 INFO TEST-PASS | /tests/dom/apps/tests/test_app_update.html | App is installed
06:06:00     INFO -  657 INFO TEST-PASS | /tests/dom/apps/tests/test_app_update.html | Checking installed app

Comment 1

[Marco Castelluccio [:marco]]

The problem is due to the test skipping the user confirmation, it doesn't really matter.

Comment 2

[Marco Castelluccio [:marco]]

Attachment: Patch

If we want to avoid the error we can take this simple fix.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

The intent is to eventually make these exceptions fatal, so yes, we want the fix.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/aa8d1c59a3ca

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/aa8d1c59a3ca