Closed Bug 910261 Opened 11 years ago Closed 11 years ago

Proxy defineProperty hooks need to be able to throw in strict mode but not in non-strict mode

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
RESOLVED DUPLICATE of bug 826587

People

(Reporter: bzbarsky, Unassigned)

References

Details

(Keywords: compat) 

Basically, proxies need to be able to make a property "look readonly" by throwing from defineProperty only in strict mode.

Right now we end up throwing in both modes, for lack of anything better, which is causing web compat issues in Firefox 23 for HTMLDocument objects.  See bug 910220.
Blocks: 910220
And I could have sworn we had a bug on this, but I can't find it.

As a workaround, I'm considering switching the DOM proxies to simply not throw in strict mode....
Severity: normal → major
Keywords: compat
This is bug 826587, which if you'll recall I mentioned a couple days ago as the thing I most wanted to fix after Intl/ES6 testing stuff wrapped up.  :-)
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
OK, so what are my options for Firefox 24, 25, 26 given the web compat breakage we have on our hands?  :(
Flags: needinfo?(jwalden+bmo)
Bug 910220 comment 6 is what I think should be done.
Flags: needinfo?(jwalden+bmo)
You need to log in before you can comment on or make changes to this bug.