91035 - IBMBIDI define changes vtables, causes nastiness for embedders

Status: RESOLVED DUPLICATE of bug 89203

(Core :: Layout: Text and Fonts, defect)

Description

[Andrew Chatham]

The define IBMBIDI is made in config-defs.h. In nsDocument.h certain functions
are ifdef'd based on the value of IBMBIDI. This creates problems for embedders,
since config-defs.h is not distributed, so you have no idea whether it was on or
off during compilation, leading to possibly incorrect. IBMBIDI is on by default
now, so an embedder can just define IBMBIDI, but it can be explicitly turned
off, and this solution is not at all obvious when you have random segfaults in
nsDocument.

Comment 1

[timeless]

there's a bug to remove support for undefining IBMBIDI which leads me to think 
this is wontfix.

Comment 2

[Steve Work]

Here's a patch that would have saved me many many hours if it had been
implemented when this bug was reported....

Comment 3

[Steve Work]

Attachment: Conditional IBMBIDI shouldn't break nsIDocument interface

Comment 4

[Steve Work]

Ooops, patch above is incomplete though correct.  nsIFrame, nsIPresContext,
nsIPresShell, nsIRenderingContext, and nsILineIterator all would need similar
attention.  This last is nasty, IBMBIDI changes a fn signature.  Can't find bug
number ref'd by [e-mail] above... if it's that easy I'll do it.

Comment 5

[Steve Work]

Sorry everybody, #89203 is (was) a work in progress to remove --disable-bidi. 
Please consider the patch here a shot across the bow to reawaken it.

Comment 6

[Keyser Sose]

Marking nEW.

Comment 7

[Simon Montagu :smontagu]

Duping to 89203.

*** This bug has been marked as a duplicate of 89203 ***