910380 - Allow persisting MIME types for blob uploads (and not serving as content-disposition: attachment)

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[(not currently active) Ted Mielczarek]

For some types of uploads it'd be nice to persist the MIME type and serve the file with that MIME type, not as content-disposition: attachment. The use cases I'm envisioning here are mostly screenshots, which we should be able to just display in the browser, and log files that we should just be able to view as text.

Comment 1

[(not currently active) Ted Mielczarek]

Your example looks pretty good (seen on IRC)! I might just go with a hard-coded list of extensions -> MIME types instead of using a MIME type guesser, I don't think we're going to have a very expansive list of files here (but I could be wrong). I noticed that the .dmp file in your example got some weird MIME type.

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

You were right. I've used in a wrong way the 'Content-Disposition' HTTP field and didn't notice that some of the files were served from the cache while testing. Sorry about that.

Changed the logic and things are now as follows:
1. Files uploaded within the blob client get by default the 'application/octetstream' mimetype
2. When they reach out the blob server, the mimetype is overwritten with a known-to-render-type should the extension of the file lies in the config file
3. the files then get uploaded on Amazon S3
4. all the files (regardless of them being to-render or to-download) preserve their filename when uploaded
5. the whitelist of extension->mime type lies in the config.py file of the blob server and thus, can easily be completed with other different types

Comment 3

[(not currently active) Ted Mielczarek]

This got fixed at some point.